Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.18] [Security Solution][Explore] Migrate from styled-components in shared (#210311) #211226

Merged
merged 2 commits into from
Feb 14, 2025

Conversation

kapral18
Copy link
Contributor

Backport

This will backport the following commits from main to 8.18:

Questions ?

Please refer to the Backport tool documentation

…elastic#210311)

Addresses elastic#206436

- Replace styled-components with @emotion/react and @emotion/styled
across multiple components
- Remove `@kbn/ui-theme` instances
- Update test cases to use @emotion/jest matchers for toHaveStyleRule to
work properly
- Adjust styles to use `css` from `@emotion/react`
- Remove unused imports and updated snapshots

https://github.com/user-attachments/assets/48b9ab41-23fd-4c00-ace9-c0cbe58c91f7
(cherry picked from commit 4b4c5ce)

# Conflicts:
#	packages/kbn-babel-preset/styled_components_files.js
#	x-pack/solutions/security/plugins/security_solution/public/common/components/charts/draggable_legend.tsx
#	x-pack/solutions/security/plugins/security_solution/public/common/components/charts/draggable_legend_item.tsx
#	x-pack/solutions/security/plugins/security_solution/public/timelines/components/netflow/__snapshots__/index.test.tsx.snap
#	x-pack/solutions/security/plugins/security_solution/public/timelines/components/timeline/body/renderers/netflow/__snapshots__/netflow_row_renderer.test.tsx.snap
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 14, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #21 / Configure renders correctly

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 9.1MB 9.1MB -14.5KB

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
securitySolution 84.4KB 84.5KB +89.0B
Unknown metric groups

async chunk count

id before after diff
securitySolution 125 126 +1

ESLint disabled line counts

id before after diff
securitySolution 579 578 -1

Total ESLint disabled count

id before after diff
securitySolution 662 661 -1

History

@kapral18 kapral18 merged commit ef85e74 into elastic:8.18 Feb 14, 2025
8 checks passed
@kapral18 kapral18 deleted the backport/8.18/pr-210311 branch February 14, 2025 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants