Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Discover] Added context aware logic for logs view in discover to show Load More… #211176

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

[Discover] Added context aware logic for logs view in discover to show Load More… #211176

wants to merge 2 commits into from

Conversation

achyutjhunjhunwala
Copy link
Contributor

@achyutjhunjhunwala achyutjhunjhunwala commented Feb 14, 2025 •
edited
Loading

Summary

Closes - #166679

What's included ?

  • The PR adds a feature in Logs View of Observability (to start with) to hide the regular pagination toolbar from the footer and show Load More only when the user has scrolled to the bottom of the page.
  • The table would always load the items in batches of default set 500

What's pending ?

  • Add all sort of tests

Feb-14-2025 15-25-18

@achyutjhunjhunwala
Added context aware logic for logs view in discover to show Load More…
4bc9040 
… for pagination rather than regular page number based pagination
@achyutjhunjhunwala achyutjhunjhunwala added release_note:feature Makes this part of the condensed release notes Team:obs-ux-logs Observability Logs User Experience Team labels Feb 14, 2025
@achyutjhunjhunwala achyutjhunjhunwala self-assigned this Feb 14, 2025
@achyutjhunjhunwala achyutjhunjhunwala requested review from a team as code owners February 14, 2025 09:45
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@achyutjhunjhunwala achyutjhunjhunwala marked this pull request as draft February 14, 2025 09:46
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 14, 2025 •
edited
Loading

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!
  • Click to trigger kibana-deploy-project-from-pr for this PR!
  • Click to trigger kibana-deploy-cloud-from-pr for this PR!

@achyutjhunjhunwala achyutjhunjhunwala added the backport:skip This commit does not require backporting label Feb 14, 2025
@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 14, 2025 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @achyutjhunjhunwala

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@achyutjhunjhunwala achyutjhunjhunwala

Labels
backport:skip This commit does not require backporting release_note:feature Makes this part of the condensed release notes Team:obs-ux-logs Observability Logs User Experience Team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achyutjhunjhunwala @elasticmachine @kibanamachine