Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.18] [ES|QL] Fix WHERE autocomplete with MATCH before LIMIT (#210607) #211001

Merged
merged 1 commit into from
Feb 13, 2025

Conversation

darnautov
Copy link
Contributor

Backport

This will backport the following commits from main to 8.18:

Questions ?

Please refer to the Backport tool documentation

\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n\n\nCo-authored-by: Dima Arnautov "}}]}] BACKPORT-->

## Summary

Related PR elastic#199032

Fixes `WHERE` autocomplete with `MATCH` before `LIMIT`.

The previous check was filtering suggestions based on all present
commands, not just the previous one.

### Checklist

- [x] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit 1ccb6db)
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.6MB 3.6MB -33.0B

@darnautov darnautov merged commit a1c53e2 into elastic:8.18 Feb 13, 2025
11 checks passed
@darnautov darnautov deleted the backport/8.18/pr-210607 branch February 13, 2025 15:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants