Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [ML] Making creation of data view during file upload optional (#210208) #210828

Merged
merged 1 commit into from
Feb 12, 2025

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…c#210208)

Adds an option override to tell the file uploader not to create a data
view once ingest has finished.
This is currently not used but should be used in the near future when
creating lookup indices from the es|ql query bar.

The PR also contains some typing clean up to remove duplication.

**Before**

![image](https://github.com/user-attachments/assets/232e8c75-c021-4b5a-ac6a-f15ebb753799)

**After**

![image](https://github.com/user-attachments/assets/de583208-410f-4fbf-94f2-a84a8ac6b690)

(cherry picked from commit 9fa8ec4)
@kibanamachine kibanamachine merged commit e2e4544 into elastic:8.x Feb 12, 2025
11 checks passed
@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #3 / Category renders allow to add new category option

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/file-upload-common 13 14 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
dataVisualizer 720.0KB 720.3KB +313.0B

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataVisualizer 28.6KB 28.7KB +84.0B
Unknown metric groups

API count

id before after diff
@kbn/file-upload-common 13 14 +1

cc @jgowdyelastic

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants