Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Search]: Fix Number type field to have correct property (#210462) #210691

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

)

## Summary

This PR includes the following updates:
- Converted `readOnly` fields to `disabled` to ensure consistency across
all view-only fields.
- Added an `isPreconfigured` check to disable the `num_allocations`
field. While `num_allocations` is the only updatable field for
`Elasticsearch` services, it cannot be modified if the endpoint is
preconfigured.

### Not preconfigured
![Screenshot 2025-02-10 at 3 54
32 PM](https://github.com/user-attachments/assets/a70aa6a4-69b5-4f75-95ba-f3793b6992d2)

### Preconfigured
![Screenshot 2025-02-10 at 3 54
19 PM](https://github.com/user-attachments/assets/4e174b33-307a-4707-974e-a91e1ca56649)

### Checklist

Check the PR satisfies following conditions.

Reviewers should verify this PR satisfies this list as well.

- [X] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios

(cherry picked from commit dc0ccc4)
@kibanamachine kibanamachine merged commit 184293d into elastic:8.x Feb 11, 2025
11 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
indexManagement 751.9KB 752.0KB +149.0B
searchInferenceEndpoints 118.8KB 118.9KB +149.0B
stackConnectors 685.3KB 685.4KB +129.0B
total +427.0B

cc @Samiul-TheSoccerFan

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants