[8.x] [Security Solution][THI] - remove usages of EUI tint, shade and transparentize functions (#205223) #210652
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…parentize functions (elastic#205223) ## Summary This PR is part of a list of PRs to perform the changes necessary to get the new Borealis theme working correctly. It focuses on removing the `shade()`, `tint()`, `shadeOrTint()`, `tintOrShade()` and `transparentize()` functions. 2 places have been impacted: - the expandable flyout preview shadow #### Light | before | after | | ------------- | ------------- | |  |  | #### Dark | before | after | | ------------- | ------------- | |  |  | - the unified data table - for row hover background color (I tried a few options here, this change is the one that looked the best to me, despite being identical color to the odd row background... I'm opened to suggestions here!) #### Light | before | after | | ------------- | ------------- | |  |  | #### Dark | before | after | | ------------- | ------------- | |  |  | - for row comparison #### Light | before | after | | ------------- | ------------- | |  |  | #### Dark | before | after | | ------------- | ------------- | |  |  | _Notes: one usage of the `transparentize` function was left untouched [here](https://github.com/elastic/kibana/blob/main/x-pack/solutions/security/plugins/security_solution/public/timelines/components/modal/index.styles.tsx#L30). This is a custom OverlayMask and this code replicates what's being done in the EUI codebase. I checked and EUI is still using the `transparentize` method with that color, so I figured I would keep this untouched for now..._ elastic#201888 --------- Co-authored-by: Davis McPhee <davis.mcphee@elastic.co> (cherry picked from commit 3057eac) # Conflicts: # x-pack/solutions/security/packages/expandable-flyout/src/components/preview_section.tsx
christineweng
approved these changes
Feb 11, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation