Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.18] [Security Solution][Alert details] do not open the SessionView detailed panel on first load (#210121) #210493

Merged
merged 1 commit into from
Feb 11, 2025

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.18:

Questions ?

Please refer to the Backport tool documentation

…ed panel on first load (elastic#210121)

## Summary

We [recently improved](elastic#200270)
the SessionView experience when visualized within the alert details
expandable flyout. One downside was that the SessionView detailed panel
was opening in the flyout preview section on first load. This was
intended at the time, to mimic the behavior of the SessionView rendered
in place of the alerts table.
This behavior is not desired in the flyout though. This PR is making a
very small code change, to ensure that the detailed panel is NOT
rendered on first load, but will be when users click on a row in the
SessionView tree (which is a behavior that exists today).

#### Previous behavior

https://github.com/user-attachments/assets/ac6c0493-5d57-4dd1-bd43-bec6b025e768

#### New behavior

https://github.com/user-attachments/assets/4ce48f4d-f04d-46f8-a6b1-693fe8983d20

The amount of code change was kept to a minimum. I basically added one
prop to the `onSelectedProcess` callback that will differentiate user
actions from automated actions. The value is `false` by default, to not
change any existing logic, except on the user click event happening in
the tree.

#### Logic not changed when displayed in place of the alerts table

https://github.com/user-attachments/assets/b54ec319-baf5-4318-a45f-405178f92888

## How to test

- turn on the `securitySolution:enableVisualizationsInFlyout` Advanced
Settings
![Screenshot 2024-12-16 at 5 05
05 PM](https://github.com/user-attachments/assets/e5a937fa-7eaf-46b3-be11-d56224daf821)
- generate alerts with data for session view (`yarn test:generate -n
http://elastic:changeme@localhost:9200 -k
http://elastic:changeme@localhost:5601`)

(cherry picked from commit ee61373)
@kibanamachine kibanamachine merged commit a0c2721 into elastic:8.18 Feb 11, 2025
11 checks passed
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
sessionView 363.6KB 363.6KB +13.0B

cc @PhilippeOberti

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants