Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Siem migrations UI telemetry #209633

Merged
merged 11 commits into from
Feb 10, 2025
Prev Previous commit
Next Next commit
solve conflicts
  • Loading branch information
semd committed Feb 6, 2025
commit 105f33840f8e0b23adc0bf4e63f7c9398351e72c
Original file line number Diff line number Diff line change
Expand Up @@ -28,9 +28,6 @@ export interface BaseResultActionParams {
result: 'success' | 'failed';
errorMessage?: string;
}
export interface BaseTranslatedRuleActionParams extends BaseResultActionParams {
migrationId: string;
}

// Setup actions

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ export const MigrationReadyPanel = React.memo<MigrationReadyPanelProps>(({ migra

const onOpenFlyout = useCallback<React.MouseEventHandler>(() => {
openFlyout(migrationStats);
telemetry.reportSetupMigrationOpenUpload({
telemetry.reportSetupMigrationOpenResources({
migrationId: migrationStats.id,
missingResourcesCount: missingResources.length,
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ export const RuleMigrationsUploadMissingPanel = React.memo<RuleMigrationsUploadM

const onOpenFlyout = useCallback(() => {
openFlyout(migrationStats);
telemetry.reportSetupMigrationOpenUpload({
telemetry.reportSetupMigrationOpenResources({
migrationId: migrationStats.id,
missingResourcesCount: missingResources.length,
});
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -50,6 +50,8 @@ import { getSuccessToast } from './notifications/success_notification';
import { RuleMigrationsStorage } from './storage';
import * as i18n from './translations';
import { SiemRulesMigrationsTelemetry } from './telemetry';
import { getNoConnectorToast } from './notifications/no_connector_notification';
import { getMissingCapabilitiesToast } from './notifications/missing_capabilities_notification';

// use the default assistant namespace since it's the only one we use
const NAMESPACE_TRACE_OPTIONS_SESSION_STORAGE_KEY =
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ export class SiemRulesMigrationsTelemetry {
this.telemetryService.reportEvent(SiemMigrationsEventTypes.SetupMigrationOpenNew, params);
};

reportSetupMigrationOpenUpload = (params: {
reportSetupMigrationOpenResources = (params: {
migrationId: string;
missingResourcesCount: number;
}) => {
Expand Down
You are viewing a condensed version of this merge commit. You can view the full changes here.