Add test to citations

x-pack/solutions/security/plugins/elastic_assistant/server/lib/prompt/prompts.test.ts

@@ -0,0 +1,17 @@
+import { BEDROCK_SYSTEM_PROMPT, DEFAULT_SYSTEM_PROMPT, GEMINI_SYSTEM_PROMPT, STRUCTURED_SYSTEM_PROMPT } from "./prompts";
+
+describe('prompts', () => {
+    it.each([
+        [DEFAULT_SYSTEM_PROMPT, '{include_citations_prompt_placeholder}', 1],
+        [GEMINI_SYSTEM_PROMPT, '{include_citations_prompt_placeholder}', 1],
+        [BEDROCK_SYSTEM_PROMPT, '{include_citations_prompt_placeholder}', 1],
+        [STRUCTURED_SYSTEM_PROMPT, '{include_citations_prompt_placeholder}', 1],
+        [DEFAULT_SYSTEM_PROMPT, 'You are a security analyst', 1],
+        [GEMINI_SYSTEM_PROMPT, 'You are an assistant', 1],
+        [BEDROCK_SYSTEM_PROMPT, 'You are a security analyst', 1],
+    ])('"%s" contains "%s" %s times', async (prompt: string, containedString: string, expectedCount: number) => {
+        const regex = new RegExp(containedString, "g");
+        expect((prompt.match(regex) || []).length).toBe(expectedCount);
+    })
+
+});

x-pack/solutions/security/plugins/elastic_assistant/server/lib/prompt/prompts.ts

@@ -20,7 +20,7 @@ const BASE_GEMINI_PROMPT =
 const KB_CATCH =
   'If the knowledge base tool gives empty results, do your best to answer the question from the perspective of an expert security analyst.';
 export const GEMINI_SYSTEM_PROMPT = `${BASE_GEMINI_PROMPT} ${KB_CATCH} {include_citations_prompt_placeholder}`;
-export const BEDROCK_SYSTEM_PROMPT = `${DEFAULT_SYSTEM_PROMPT} Use tools as often as possible, as they have access to the latest data and syntax. Never return <thinking> tags in the response, but make sure to include <result> tags content in the response. Do not reflect on the quality of the returned search results in your response. {include_citations_prompt_placeholder} ALWAYS return the exact response from NaturalLanguageESQLTool verbatim in the final response, without adding further description.`;
+export const BEDROCK_SYSTEM_PROMPT = `${DEFAULT_SYSTEM_PROMPT} Use tools as often as possible, as they have access to the latest data and syntax. Never return <thinking> tags in the response, but make sure to include <result> tags content in the response. Do not reflect on the quality of the returned search results in your response. ALWAYS return the exact response from NaturalLanguageESQLTool verbatim in the final response, without adding further description.`;
 export const GEMINI_USER_PROMPT = `Now, always using the tools at your disposal, step by step, come up with a response to this request:\n\n`;
 
 export const STRUCTURED_SYSTEM_PROMPT = `Respond to the human as helpfully and accurately as possible. ${KNOWLEDGE_HISTORY} {include_citations_prompt_placeholder} You have access to the following tools: