Fix notify_badge.tsx toggle not working #208996
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At the moment, when you click on the notify badge in the "rules" page, then click it again (expecting a toggle) it actually gets stuck on the page and only a refresh can fix it. This change adds a toggle and implements it in place of the "openPopover" to correctly toggle the state of the popover.
Fixing another case that was missed for indefinitesnooze.
A minor bug with this change is that the bell icon stayed shown until a click was registered elsewhere in the screen. This adjustment fixes this - keeping the closepopover/togglepopover functional, but also fixing the minor problem with the bell icon remaining stuck/not respecting hoverover.
💔 Build Failed
Failed CI StepsHistory |
adcoelho
approved these changes
Jan 31, 2025
cnasikas
added
Team:ResponseOps
|
Pinging @elastic/response-ops (Team:ResponseOps) |
cnasikas
added
the
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
At the moment, when you click on the notify badge in the "rules" page, then click it again (expecting a toggle) it actually gets stuck on the page and only a refresh can fix it.
This change adds a toggle and implements it in place of the "openPopover" to correctly toggle the state of the popover.
Checklist
release_note:*label is applied per the guidelinesRelease Notes
Fixes an issue where the popover in the rules page may get stuck when being clicked more than once.
Before:
Screen.Recording.2025-01-30.at.17.10.37.mov
After:
Screen.Recording.2025-01-30.at.19.14.00.mov