[kbn-grid-layout] Disable pointer events on drag + resize #208647
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Heenawter
added
release_note:enhancement
Feature:Dashboard
Heenawter
changed the title
kbn-grid-layout] Disable pointer events on drag + resize
Heenawter
added
release_note:skip
|
Pinging @elastic/kibana-presentation (Team:Presentation) |
Heenawter
added
bug
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]Async chunks
History
cc @Heenawter |
nickpeihl
approved these changes
Feb 3, 2025
Heenawter
deleted the
kbn-grid-layout_disable-pointer-events_2025-01-28
branch
|
Starting backport for target branches: 8.18, 8.x, 9.0 |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 3, 2025
…8647) ## Summary This PR greatly improves the performance of `kbn-grid-layout` on drag + resize by disabling pointer events during these actions. This is especially evident when dragging over panels that have their own mouse event listeners. | Before | After | |--------|--------| |  |  | |  |  | |  |  | ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 6cc788c)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 3, 2025
…8647) ## Summary This PR greatly improves the performance of `kbn-grid-layout` on drag + resize by disabling pointer events during these actions. This is especially evident when dragging over panels that have their own mouse event listeners. | Before | After | |--------|--------| |  |  | |  |  | |  |  | ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 6cc788c)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Feb 3, 2025
…8647) ## Summary This PR greatly improves the performance of `kbn-grid-layout` on drag + resize by disabling pointer events during these actions. This is especially evident when dragging over panels that have their own mouse event listeners. | Before | After | |--------|--------| |  |  | |  |  | |  |  | ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) (cherry picked from commit 6cc788c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Feb 4, 2025
) (#209423) # Backport This will backport the following commits from `main` to `8.x`: - [[kbn-grid-layout] Disable pointer events on drag + resize (#208647)](#208647) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Hannah Mudge","email":"Heenawter@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-03T22:43:24Z","message":"[kbn-grid-layout] Disable pointer events on drag + resize (#208647)\n\n## Summary\r\n\r\nThis PR greatly improves the performance of `kbn-grid-layout` on drag +\r\nresize by disabling pointer events during these actions. This is\r\nespecially evident when dragging over panels that have their own mouse\r\nevent listeners.\r\n\r\n| Before | After |\r\n|--------|--------|\r\n|\r\n\r\n|\r\n\r\n|\r\n|\r\n\r\n|\r\n\r\n|\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\n### Checklist\r\n\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6cc788c4b17fdb627feeceadd457c425478eefd1","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Dashboard","release_note:fix","performance","Team:Presentation","loe:small","impact:high","v9.0.0","Project:Collapsable Panels","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[kbn-grid-layout] Disable pointer events on drag + resize","number":208647,"url":"https://github.com/elastic/kibana/pull/208647","mergeCommit":{"message":"[kbn-grid-layout] Disable pointer events on drag + resize (#208647)\n\n## Summary\r\n\r\nThis PR greatly improves the performance of `kbn-grid-layout` on drag +\r\nresize by disabling pointer events during these actions. This is\r\nespecially evident when dragging over panels that have their own mouse\r\nevent listeners.\r\n\r\n| Before | After |\r\n|--------|--------|\r\n|\r\n\r\n|\r\n\r\n|\r\n|\r\n\r\n|\r\n\r\n|\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\n### Checklist\r\n\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6cc788c4b17fdb627feeceadd457c425478eefd1"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208647","number":208647,"mergeCommit":{"message":"[kbn-grid-layout] Disable pointer events on drag + resize (#208647)\n\n## Summary\r\n\r\nThis PR greatly improves the performance of `kbn-grid-layout` on drag +\r\nresize by disabling pointer events during these actions. This is\r\nespecially evident when dragging over panels that have their own mouse\r\nevent listeners.\r\n\r\n| Before | After |\r\n|--------|--------|\r\n|\r\n\r\n|\r\n\r\n|\r\n|\r\n\r\n|\r\n\r\n|\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\n### Checklist\r\n\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6cc788c4b17fdb627feeceadd457c425478eefd1"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Feb 4, 2025
…8647) (#209422) # Backport This will backport the following commits from `main` to `8.18`: - [[kbn-grid-layout] Disable pointer events on drag + resize (#208647)](#208647) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Hannah Mudge","email":"Heenawter@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-03T22:43:24Z","message":"[kbn-grid-layout] Disable pointer events on drag + resize (#208647)\n\n## Summary\r\n\r\nThis PR greatly improves the performance of `kbn-grid-layout` on drag +\r\nresize by disabling pointer events during these actions. This is\r\nespecially evident when dragging over panels that have their own mouse\r\nevent listeners.\r\n\r\n| Before | After |\r\n|--------|--------|\r\n|\r\n\r\n|\r\n\r\n|\r\n|\r\n\r\n|\r\n\r\n|\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\n### Checklist\r\n\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6cc788c4b17fdb627feeceadd457c425478eefd1","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Dashboard","release_note:fix","performance","Team:Presentation","loe:small","impact:high","v9.0.0","Project:Collapsable Panels","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[kbn-grid-layout] Disable pointer events on drag + resize","number":208647,"url":"https://github.com/elastic/kibana/pull/208647","mergeCommit":{"message":"[kbn-grid-layout] Disable pointer events on drag + resize (#208647)\n\n## Summary\r\n\r\nThis PR greatly improves the performance of `kbn-grid-layout` on drag +\r\nresize by disabling pointer events during these actions. This is\r\nespecially evident when dragging over panels that have their own mouse\r\nevent listeners.\r\n\r\n| Before | After |\r\n|--------|--------|\r\n|\r\n\r\n|\r\n\r\n|\r\n|\r\n\r\n|\r\n\r\n|\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\n### Checklist\r\n\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6cc788c4b17fdb627feeceadd457c425478eefd1"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208647","number":208647,"mergeCommit":{"message":"[kbn-grid-layout] Disable pointer events on drag + resize (#208647)\n\n## Summary\r\n\r\nThis PR greatly improves the performance of `kbn-grid-layout` on drag +\r\nresize by disabling pointer events during these actions. This is\r\nespecially evident when dragging over panels that have their own mouse\r\nevent listeners.\r\n\r\n| Before | After |\r\n|--------|--------|\r\n|\r\n\r\n|\r\n\r\n|\r\n|\r\n\r\n|\r\n\r\n|\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\n### Checklist\r\n\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6cc788c4b17fdb627feeceadd457c425478eefd1"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>
kibanamachine
added a commit
that referenced
this pull request
Feb 4, 2025
) (#209424) # Backport This will backport the following commits from `main` to `9.0`: - [[kbn-grid-layout] Disable pointer events on drag + resize (#208647)](#208647) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Hannah Mudge","email":"Heenawter@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-03T22:43:24Z","message":"[kbn-grid-layout] Disable pointer events on drag + resize (#208647)\n\n## Summary\r\n\r\nThis PR greatly improves the performance of `kbn-grid-layout` on drag +\r\nresize by disabling pointer events during these actions. This is\r\nespecially evident when dragging over panels that have their own mouse\r\nevent listeners.\r\n\r\n| Before | After |\r\n|--------|--------|\r\n|\r\n\r\n|\r\n\r\n|\r\n|\r\n\r\n|\r\n\r\n|\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\n### Checklist\r\n\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6cc788c4b17fdb627feeceadd457c425478eefd1","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Feature:Dashboard","release_note:fix","performance","Team:Presentation","loe:small","impact:high","v9.0.0","Project:Collapsable Panels","backport:version","v8.18.0","v9.1.0","v8.19.0"],"title":"[kbn-grid-layout] Disable pointer events on drag + resize","number":208647,"url":"https://github.com/elastic/kibana/pull/208647","mergeCommit":{"message":"[kbn-grid-layout] Disable pointer events on drag + resize (#208647)\n\n## Summary\r\n\r\nThis PR greatly improves the performance of `kbn-grid-layout` on drag +\r\nresize by disabling pointer events during these actions. This is\r\nespecially evident when dragging over panels that have their own mouse\r\nevent listeners.\r\n\r\n| Before | After |\r\n|--------|--------|\r\n|\r\n\r\n|\r\n\r\n|\r\n|\r\n\r\n|\r\n\r\n|\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\n### Checklist\r\n\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6cc788c4b17fdb627feeceadd457c425478eefd1"}},"sourceBranch":"main","suggestedTargetBranches":["9.0","8.18","8.x"],"targetPullRequestStates":[{"branch":"9.0","label":"v9.0.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.18","label":"v8.18.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/208647","number":208647,"mergeCommit":{"message":"[kbn-grid-layout] Disable pointer events on drag + resize (#208647)\n\n## Summary\r\n\r\nThis PR greatly improves the performance of `kbn-grid-layout` on drag +\r\nresize by disabling pointer events during these actions. This is\r\nespecially evident when dragging over panels that have their own mouse\r\nevent listeners.\r\n\r\n| Before | After |\r\n|--------|--------|\r\n|\r\n\r\n|\r\n\r\n|\r\n|\r\n\r\n|\r\n\r\n|\r\n|\r\n\r\n|\r\n\r\n|\r\n\r\n### Checklist\r\n\r\n- [x] The PR description includes the appropriate Release Notes section,\r\nand the correct `release_note:*` label is applied per the\r\n[guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)","sha":"6cc788c4b17fdb627feeceadd457c425478eefd1"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Hannah Mudge <Heenawter@users.noreply.github.com>
drewdaemon
pushed a commit
to drewdaemon/kibana
that referenced
this pull request
Feb 6, 2025
…8647) ## Summary This PR greatly improves the performance of `kbn-grid-layout` on drag + resize by disabling pointer events during these actions. This is especially evident when dragging over panels that have their own mouse event listeners. | Before | After | |--------|--------| |  |  | |  |  | |  |  | ### Checklist - [x] The PR description includes the appropriate Release Notes section, and the correct `release_note:*` label is applied per the [guidelines](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR greatly improves the performance of
kbn-grid-layouton drag + resize by disabling pointer events during these actions. This is especially evident when dragging over panels that have their own mouse event listeners.Checklist
release_note:*label is applied per the guidelines