[ResponseOps][Alerts] Move the alerts table to a dedicated package #207878
+11,945
−11,898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
umbopepato
force-pushed
the
alerts-table-refactor
branch
from
99c6d4d to
72b83e5
Compare
umbopepato
added
release_note:skip
umbopepato
force-pushed
the
alerts-table-refactor
branch
from
72b83e5 to
002f502
Compare
|
Pinging @elastic/response-ops (Team:ResponseOps) |
umbopepato
requested review from
machadoum,
pzl,
szwarckonrad,
nkhristinin and
nikitaindik
jennypavlova
approved these changes
Jan 23, 2025
packages/response-ops/alerts_table/components/alerts_data_grid.tsx
Outdated
Show resolved
Hide resolved
umbopepato
force-pushed
the
alerts-table-refactor
branch
from
444e9cd to
2fa4664
Compare
|
Starting backport for target branches: 9.0 |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
async chunk count
ESLint disabled in files
ESLint disabled line counts
miscellaneous assets size
References to deprecated APIs
Total ESLint disabled count
History
|
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
umbopepato
added a commit
to umbopepato/kibana
that referenced
this pull request
Feb 12, 2025
…lastic#207878) ## Summary This PR turns the AlertsTable into a standalone component, making it independent from the `TriggersActionsUI` plugin. #### Removes the alerts table registry All configuration is now managed through the AlertsTable component props. Shared configurations are handled by giving consumers the ability to directly provide alerts table wrapper components (see for example the `renderAlertsTable` prop of `getCases`). #### Moves the alerts table to dedicated package(s) Following the feature-driven structure we're introducing for ResponseOps (alerting) client-side packages: - `@kbn/response-ops-alerts-table` - `@kbn/response-ops-alerts-apis` - `@kbn/response-ops-alerts-fields-browser` #### Initial work on improving composition and organization - Reorganizes the table code into a by-entity-type folder structure (`components/`, `hooks/`, ...) - Simplifies some components and breaks into smaller units when possible ## To verify For consumers of the alerts table: - Check that all your tables have the same behavior as before (columns, sort, row actions, bulk actions, etc.) - Check that your "shared" tables (i.e. cases alerts view in O11y and Security) have the expected configuration and behavior > [!WARNING] > This PR moves a lot of files. Git might not always recognize the correct delete/add file pairs. If you see weird diffs feel free to reach out for help! ### Checklist - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed ### Identify risks | Risk | Description | Severity | Mitigation | |---|---|---|---| | Table misconfigurations | Some table configurations might slightly differ from the previous AlertsTableRegistry-backed version | Low | Quick fix | ## References Closes elastic#195180 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Christos Nasikas <xristosnasikas@gmail.com> (cherry picked from commit a74066d) # Conflicts: # x-pack/solutions/security/plugins/security_solution/public/detections/components/alerts_table/index.tsx # x-pack/solutions/security/plugins/security_solution/public/detections/configurations/security_solution_detections/render_cell_value.tsx # x-pack/solutions/security/plugins/security_solution/public/timelines/components/timeline/body/renderers/user_profile_renderer.tsx
umbopepato
added
backport:prev-major
|
Starting backport for target branches: 8.16, 8.17, 8.18, 8.x |
umbopepato
removed
the
backport:prev-major
umbopepato
added
backport:version
|
Starting backport for target branches: 8.x |
|
Starting backport for target branches: 8.x |
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
1 similar comment
💔 All backports failed
Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
umbopepato
added a commit
to umbopepato/kibana
that referenced
this pull request
Feb 12, 2025
…lastic#207878) ## Summary This PR turns the AlertsTable into a standalone component, making it independent from the `TriggersActionsUI` plugin. #### Removes the alerts table registry All configuration is now managed through the AlertsTable component props. Shared configurations are handled by giving consumers the ability to directly provide alerts table wrapper components (see for example the `renderAlertsTable` prop of `getCases`). #### Moves the alerts table to dedicated package(s) Following the feature-driven structure we're introducing for ResponseOps (alerting) client-side packages: - `@kbn/response-ops-alerts-table` - `@kbn/response-ops-alerts-apis` - `@kbn/response-ops-alerts-fields-browser` #### Initial work on improving composition and organization - Reorganizes the table code into a by-entity-type folder structure (`components/`, `hooks/`, ...) - Simplifies some components and breaks into smaller units when possible ## To verify For consumers of the alerts table: - Check that all your tables have the same behavior as before (columns, sort, row actions, bulk actions, etc.) - Check that your "shared" tables (i.e. cases alerts view in O11y and Security) have the expected configuration and behavior > [!WARNING] > This PR moves a lot of files. Git might not always recognize the correct delete/add file pairs. If you see weird diffs feel free to reach out for help! ### Checklist - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios - [ ] [Flaky Test Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was used on any tests changed ### Identify risks | Risk | Description | Severity | Mitigation | |---|---|---|---| | Table misconfigurations | Some table configurations might slightly differ from the previous AlertsTableRegistry-backed version | Low | Quick fix | ## References Closes elastic#195180 --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Christos Nasikas <xristosnasikas@gmail.com> (cherry picked from commit a74066d) # Conflicts: # .github/CODEOWNERS # packages/response-ops/alerts_table/components/alert_lifecycle_status_cell.tsx # src/platform/packages/shared/kbn-alerts-ui-shared/src/alert_fields_table/index.tsx # x-pack/platform/plugins/private/translations/translations/zh-CN.json # x-pack/solutions/security/plugins/security_solution/public/detections/components/alerts_kpis/severity_level_panel/severity_level_chart.tsx # x-pack/solutions/security/plugins/security_solution/public/detections/components/alerts_table/index.tsx # x-pack/solutions/security/plugins/security_solution/public/detections/hooks/trigger_actions_alert_table/use_persistent_controls.tsx # x-pack/test/functional_with_es_ssl/apps/cases/group1/view_case.ts
umbopepato
added a commit
that referenced
this pull request
Feb 13, 2025
…age (#207878) (#210895) # Backport This will backport the following commits from `main` to `8.x`: - [[ResponseOps][Alerts] Move the alerts table to a dedicated package (#207878)](#207878) <!--- Backport version: 9.6.4 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sorenlouv/backport) <!--BACKPORT [{"author":{"name":"Umberto Pepato","email":"umbopepato@users.noreply.github.com"},"sourceCommit":{"committedDate":"2025-02-12T10:07:55Z","message":"[ResponseOps][Alerts] Move the alerts table to a dedicated package (#207878)\n\n## Summary\r\n\r\nThis PR turns the AlertsTable into a standalone component, making it\r\nindependent from the `TriggersActionsUI` plugin.\r\n\r\n#### Removes the alerts table registry\r\n\r\nAll configuration is now managed through the AlertsTable component\r\nprops. Shared configurations are handled by giving consumers the ability\r\nto directly provide alerts table wrapper components (see for example the\r\n`renderAlertsTable` prop of `getCases`).\r\n\r\n#### Moves the alerts table to dedicated package(s)\r\n\r\nFollowing the feature-driven structure we're introducing for ResponseOps\r\n(alerting) client-side packages:\r\n- `@kbn/response-ops-alerts-table`\r\n- `@kbn/response-ops-alerts-apis`\r\n- `@kbn/response-ops-alerts-fields-browser`\r\n\r\n#### Initial work on improving composition and organization\r\n\r\n- Reorganizes the table code into a by-entity-type folder structure\r\n(`components/`, `hooks/`, ...)\r\n- Simplifies some components and breaks into smaller units when possible\r\n\r\n## To verify\r\n\r\nFor consumers of the alerts table:\r\n- Check that all your tables have the same behavior as before (columns,\r\nsort, row actions, bulk actions, etc.)\r\n- Check that your \"shared\" tables (i.e. cases alerts view in O11y and\r\nSecurity) have the expected configuration and behavior\r\n\r\n> [!WARNING]\r\n> This PR moves a lot of files. Git might not always recognize the\r\ncorrect delete/add file pairs. If you see weird diffs feel free to reach\r\nout for help!\r\n\r\n### Checklist\r\n\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n### Identify risks\r\n\r\n| Risk | Description | Severity | Mitigation |\r\n|---|---|---|---|\r\n| Table misconfigurations | Some table configurations might slightly\r\ndiffer from the previous AlertsTableRegistry-backed version | Low |\r\nQuick fix |\r\n\r\n## References\r\n\r\nCloses #195180\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Christos Nasikas <xristosnasikas@gmail.com>","sha":"a74066d6f83fc38feaa4d7e7b1cf7d3afd53c6f7","branchLabelMapping":{"^v9.1.0$":"main","^v8.19.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","backport:version","v9.1.0","v8.19.0"],"title":"[ResponseOps][Alerts] Move the alerts table to a dedicated package","number":207878,"url":"https://github.com/elastic/kibana/pull/207878","mergeCommit":{"message":"[ResponseOps][Alerts] Move the alerts table to a dedicated package (#207878)\n\n## Summary\r\n\r\nThis PR turns the AlertsTable into a standalone component, making it\r\nindependent from the `TriggersActionsUI` plugin.\r\n\r\n#### Removes the alerts table registry\r\n\r\nAll configuration is now managed through the AlertsTable component\r\nprops. Shared configurations are handled by giving consumers the ability\r\nto directly provide alerts table wrapper components (see for example the\r\n`renderAlertsTable` prop of `getCases`).\r\n\r\n#### Moves the alerts table to dedicated package(s)\r\n\r\nFollowing the feature-driven structure we're introducing for ResponseOps\r\n(alerting) client-side packages:\r\n- `@kbn/response-ops-alerts-table`\r\n- `@kbn/response-ops-alerts-apis`\r\n- `@kbn/response-ops-alerts-fields-browser`\r\n\r\n#### Initial work on improving composition and organization\r\n\r\n- Reorganizes the table code into a by-entity-type folder structure\r\n(`components/`, `hooks/`, ...)\r\n- Simplifies some components and breaks into smaller units when possible\r\n\r\n## To verify\r\n\r\nFor consumers of the alerts table:\r\n- Check that all your tables have the same behavior as before (columns,\r\nsort, row actions, bulk actions, etc.)\r\n- Check that your \"shared\" tables (i.e. cases alerts view in O11y and\r\nSecurity) have the expected configuration and behavior\r\n\r\n> [!WARNING]\r\n> This PR moves a lot of files. Git might not always recognize the\r\ncorrect delete/add file pairs. If you see weird diffs feel free to reach\r\nout for help!\r\n\r\n### Checklist\r\n\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n### Identify risks\r\n\r\n| Risk | Description | Severity | Mitigation |\r\n|---|---|---|---|\r\n| Table misconfigurations | Some table configurations might slightly\r\ndiffer from the previous AlertsTableRegistry-backed version | Low |\r\nQuick fix |\r\n\r\n## References\r\n\r\nCloses #195180\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Christos Nasikas <xristosnasikas@gmail.com>","sha":"a74066d6f83fc38feaa4d7e7b1cf7d3afd53c6f7"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.1.0","branchLabelMappingKey":"^v9.1.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/207878","number":207878,"mergeCommit":{"message":"[ResponseOps][Alerts] Move the alerts table to a dedicated package (#207878)\n\n## Summary\r\n\r\nThis PR turns the AlertsTable into a standalone component, making it\r\nindependent from the `TriggersActionsUI` plugin.\r\n\r\n#### Removes the alerts table registry\r\n\r\nAll configuration is now managed through the AlertsTable component\r\nprops. Shared configurations are handled by giving consumers the ability\r\nto directly provide alerts table wrapper components (see for example the\r\n`renderAlertsTable` prop of `getCases`).\r\n\r\n#### Moves the alerts table to dedicated package(s)\r\n\r\nFollowing the feature-driven structure we're introducing for ResponseOps\r\n(alerting) client-side packages:\r\n- `@kbn/response-ops-alerts-table`\r\n- `@kbn/response-ops-alerts-apis`\r\n- `@kbn/response-ops-alerts-fields-browser`\r\n\r\n#### Initial work on improving composition and organization\r\n\r\n- Reorganizes the table code into a by-entity-type folder structure\r\n(`components/`, `hooks/`, ...)\r\n- Simplifies some components and breaks into smaller units when possible\r\n\r\n## To verify\r\n\r\nFor consumers of the alerts table:\r\n- Check that all your tables have the same behavior as before (columns,\r\nsort, row actions, bulk actions, etc.)\r\n- Check that your \"shared\" tables (i.e. cases alerts view in O11y and\r\nSecurity) have the expected configuration and behavior\r\n\r\n> [!WARNING]\r\n> This PR moves a lot of files. Git might not always recognize the\r\ncorrect delete/add file pairs. If you see weird diffs feel free to reach\r\nout for help!\r\n\r\n### Checklist\r\n\r\n- [x]\r\n[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)\r\nwas added for features that require explanation or tutorials\r\n- [x] [Unit or functional\r\ntests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)\r\nwere updated or added to match the most common scenarios\r\n- [ ] [Flaky Test\r\nRunner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was\r\nused on any tests changed\r\n\r\n### Identify risks\r\n\r\n| Risk | Description | Severity | Mitigation |\r\n|---|---|---|---|\r\n| Table misconfigurations | Some table configurations might slightly\r\ndiffer from the previous AlertsTableRegistry-backed version | Low |\r\nQuick fix |\r\n\r\n## References\r\n\r\nCloses #195180\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Christos Nasikas <xristosnasikas@gmail.com>","sha":"a74066d6f83fc38feaa4d7e7b1cf7d3afd53c6f7"}},{"branch":"8.x","label":"v8.19.0","branchLabelMappingKey":"^v8.19.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
|
Too bad I just discovered this. Packages should no longer go into /packages folder at the root. ❗ |
|
Apologies @gsoldevila, I was 100% sure we coordinated with you to postpone the move after this PR was merged because of its massive size and the fact that git was already struggling to recognize the moved+changed file pairs. I'll tackle this myself asap (have been busy with fixes) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR turns the AlertsTable into a standalone component, making it independent from the
TriggersActionsUIplugin.Removes the alerts table registry
All configuration is now managed through the AlertsTable component props. Shared configurations are handled by giving consumers the ability to directly provide alerts table wrapper components (see for example the
renderAlertsTableprop ofgetCases).Moves the alerts table to dedicated package(s)
Following the feature-driven structure we're introducing for ResponseOps (alerting) client-side packages:
@kbn/response-ops-alerts-table@kbn/response-ops-alerts-apis@kbn/response-ops-alerts-fields-browserInitial work on improving composition and organization
components/,hooks/, ...)To verify
For consumers of the alerts table:
Warning
This PR moves a lot of files. Git might not always recognize the correct delete/add file pairs. If you see weird diffs feel free to reach out for help!
Checklist
Identify risks
References
Closes #195180