Implement Asset Inventory filters #207094

albertoblaz · 2025-01-17T15:31:42Z

Summary

Closes #201710.

Implements filters section for Asset Inventory reusing FilterGroup component from @kbn/alerts-ui-shared package.

Screenshot

Definition of done

Add multiple dropdown filters labelled:
- Type - filter by asset.category
- Criticality - filter by asset.criticality
- Tags - filter by asset.tags.name
- Name - filter TBD
Ensure each dropdown allows users to select multiple options to filter the inventory data.
Add a button or dropdown labeled "More filters" that exposes advanced filtering options, including "Reset control" and "Edit control".
Verify if the FilterGroup component from packages/kbn-alerts-ui-shared can be reused to wrap the required functionalities.
- It can be reused, but the detection engine uses AlertFilterControls instead, which is a higher-level alternative. And that's what I did in Asset Inventory too
Ensure the filters are functional on the front-end and can interact with placeholder data.

Out of scope

Backend data filtering logic
Implementation of the actual data fetching based on filters

How to test

Follow the "how to test" instructions written on this PR:

Implement Asset Inventory data grid #206115

Checklist

This was checked for breaking HTTP API changes, and any breaking changes have been approved by the breaking-change committee. The release_note:breaking label should be applied in these situations.
The PR description includes the appropriate Release Notes section, and the correct release_note:* label is applied per the guidelines

Risks

No risks at all.

opauloh · 2025-01-27T14:34:30Z

...k/solutions/security/plugins/security_solution/public/asset_inventory/components/filters.tsx

+
+  const setFilterControlsUrlState = useCallback(
+    (newFilterControls: FilterControlConfig[]) => {
+      urlStorage.set(URL_PARAM_KEY.pageFilter, newFilterControls);


I think we are going to have a conflict with the Alerts page if we reuse the same key URL_PARAM_KEY.pageFilter, it seems we are going to need to create our own key for assetInventoryPage on https://github.com/elastic/kibana/blob/da25d13a2ac5be97216e202bf5d6bda6ff920b3b/x-pack/solutions/security/plugins/security_solution/public/common/hooks/use_url_state.ts

albertoblaz · 2025-01-31T11:43:11Z

...ons/security/plugins/security_solution/public/asset_inventory/components/filters/filters.tsx

+const SECURITY_ASSET_INVENTORY_DATA_VIEW = {
+  id: 'asset-inventory-logs-default',
+  name: 'asset-inventory-logs',
+};


Note: This is temporary and will be deleted in the follow-up PR that integrates the UI with the backend

albertoblaz · 2025-01-31T11:44:05Z

...ons/security/plugins/security_solution/public/asset_inventory/components/filters/filters.tsx

+  },
+  {
+    title: 'Name',
+    fieldName: 'asset.name', // TODO this is TBD


Question: @opauloh do we know if this eventually asset.name or agent.name or any other value?

cc @tinnytintin10, I also asked if it should be entity.name here.

If I set it to 'entity.name' I get "Bad Request".

Leaving it for now as 'asset.name' until further change.

albertoblaz · 2025-01-31T11:46:23Z

...ons/security/plugins/security_solution/public/asset_inventory/components/filters/filters.tsx

+  // TODO Remove dataView prop when integrating with backend (fetched from hook)
+  dataView: DataView;


Not sure of keeping as is because dataView is fetched by the parent (AllAssets).

...ecurity/plugins/security_solution/public/asset_inventory/components/filters/rule_type_ids.ts

x-pack/solutions/security/plugins/security_solution/public/common/hooks/use_url_state.ts

elasticmachine · 2025-01-31T12:21:50Z

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

...ons/security/plugins/security_solution/public/asset_inventory/components/filters/filters.tsx

opauloh · 2025-01-31T20:50:37Z

...ons/security/plugins/security_solution/public/asset_inventory/components/filters/filters.tsx

+  },
+  {
+    title: 'Name',
+    fieldName: 'asset.name', // TODO this is TBD


cc @tinnytintin10, I also asked if it should be entity.name here.

...ecurity/plugins/security_solution/public/asset_inventory/components/filters/rule_type_ids.ts

...ons/security/plugins/security_solution/public/asset_inventory/components/filters/filters.tsx

x-pack/solutions/security/plugins/security_solution/public/common/hooks/use_url_state.ts

seanrathier

I left a few comments for consideration. We should try a and separate the business login from our components.

...ons/security/plugins/security_solution/public/asset_inventory/components/filters/filters.tsx

albertoblaz · 2025-02-10T11:17:15Z

@elasticmachine merge upstream

seanrathier

Approving my requests and questions.

elasticmachine · 2025-02-11T20:27:02Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 76d5f7c

Failed CI Steps

x-pack/test_serverless/functional/test_suites/security/common_configs/config.group5.ts

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
`securitySolution`	6697	6700	+3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	21.4MB	21.4MB	+3.3KB

Unknown metric groups

References to deprecated APIs

id	before	after	diff
`securitySolution`	357	358	+1

History

💛 Build #275071 was flaky 7870f22
💛 Build #274636 was flaky 7835ab5
💚 Build #273200 succeeded 9ab06d4
💔 Build #272410 failed b495df0
💔 Build #272266 failed 0a0e705

cc @albertoblaz

opauloh

🚀

albertoblaz added release_note:skip Skip the PR/issue when compiling release notes backport:skip This commit does not require backporting Team:Cloud Security Cloud Security team related labels Jan 17, 2025

albertoblaz self-assigned this Jan 17, 2025

albertoblaz force-pushed the asset-inv-filters branch 3 times, most recently from cbed18c to 5301e40 Compare January 20, 2025 16:52

opauloh reviewed Jan 27, 2025

View reviewed changes

albertoblaz force-pushed the asset-inv-filters branch 2 times, most recently from 082b98d to 0a0e705 Compare January 31, 2025 11:40

albertoblaz commented Jan 31, 2025

View reviewed changes

albertoblaz requested a review from opauloh January 31, 2025 12:21

albertoblaz marked this pull request as ready for review January 31, 2025 12:21

albertoblaz requested review from a team as code owners January 31, 2025 12:21

opauloh requested changes Jan 31, 2025

View reviewed changes

seanrathier reviewed Feb 3, 2025

View reviewed changes

albertoblaz force-pushed the asset-inv-filters branch from b495df0 to 9ab06d4 Compare February 4, 2025 15:19

albertoblaz requested a review from opauloh February 4, 2025 15:20

albertoblaz enabled auto-merge (squash) February 11, 2025 11:24

Implement Asset Inventory filters UI

7870f22

albertoblaz force-pushed the asset-inv-filters branch from 7835ab5 to 7870f22 Compare February 11, 2025 11:27

albertoblaz disabled auto-merge February 11, 2025 18:15

Post-review feedback & avoid local storage collision

76d5f7c

seanrathier approved these changes Feb 11, 2025

View reviewed changes

albertoblaz enabled auto-merge (squash) February 11, 2025 18:58

opauloh approved these changes Feb 11, 2025

View reviewed changes

albertoblaz merged commit 00388ed into elastic:main Feb 11, 2025
9 checks passed

kibanamachine added the v9.1.0 label Feb 11, 2025

albertoblaz deleted the asset-inv-filters branch February 12, 2025 07:29

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement Asset Inventory filters #207094

Implement Asset Inventory filters #207094

albertoblaz commented Jan 17, 2025 •

edited

Loading

opauloh Jan 27, 2025 •

edited

Loading

albertoblaz Jan 31, 2025

albertoblaz Jan 31, 2025

opauloh Jan 31, 2025 •

edited

Loading

albertoblaz Feb 4, 2025

albertoblaz Jan 31, 2025

elasticmachine commented Jan 31, 2025

opauloh Jan 31, 2025 •

edited

Loading

seanrathier left a comment

albertoblaz commented Feb 10, 2025

seanrathier left a comment

elasticmachine commented Feb 11, 2025

References to deprecated APIs

opauloh left a comment

		// TODO Remove dataView prop when integrating with backend (fetched from hook)
		dataView: DataView;

Implement Asset Inventory filters #207094

Implement Asset Inventory filters #207094

Conversation

albertoblaz commented Jan 17, 2025 • edited Loading

Summary

Screenshot

Definition of done

Out of scope

How to test

Checklist

Risks

opauloh Jan 27, 2025 • edited Loading

Choose a reason for hiding this comment

albertoblaz Jan 31, 2025

Choose a reason for hiding this comment

albertoblaz Jan 31, 2025

Choose a reason for hiding this comment

opauloh Jan 31, 2025 • edited Loading

Choose a reason for hiding this comment

albertoblaz Feb 4, 2025

Choose a reason for hiding this comment

albertoblaz Jan 31, 2025

Choose a reason for hiding this comment

elasticmachine commented Jan 31, 2025

opauloh Jan 31, 2025 • edited Loading

Choose a reason for hiding this comment

seanrathier left a comment

Choose a reason for hiding this comment

albertoblaz commented Feb 10, 2025

seanrathier left a comment

Choose a reason for hiding this comment

elasticmachine commented Feb 11, 2025

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Module Count

Async chunks

References to deprecated APIs

History

opauloh left a comment

Choose a reason for hiding this comment

albertoblaz commented Jan 17, 2025 •

edited

Loading

opauloh Jan 27, 2025 •

edited

Loading

opauloh Jan 31, 2025 •

edited

Loading

opauloh Jan 31, 2025 •

edited

Loading