-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core.http] Add warning header to deprecated endpoints #205926
Draft
jesuswr
wants to merge
7
commits into
elastic:main
Choose a base branch
from
jesuswr:add-warning-header-to-deprecated-endpoints
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
[core.http] Add warning header to deprecated endpoints #205926
jesuswr
wants to merge
7
commits into
elastic:main
from
jesuswr:add-warning-header-to-deprecated-endpoints
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 Jobs for this PR can be triggered through checkboxes. 🚧
ℹ️ To trigger the CI, please tick the checkbox below 👇
|
jesuswr
changed the title
Add warning header to deprecated endpoints
[core.http] Add warning header to deprecated endpoints
Jan 8, 2025
jesuswr
added
Feature:http
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
backport:skip
This commit does not require backporting
release_note:skip
Skip the PR/issue when compiling release notes
release_note:enhancement
and removed
release_note:skip
Skip the PR/issue when compiling release notes
labels
Jan 8, 2025
/ci |
1 similar comment
/ci |
💔 Build Failed
Failed CI Steps
Test Failures
Metrics [docs]
History
cc @jesuswr |
jesuswr
force-pushed
the
add-warning-header-to-deprecated-endpoints
branch
from
January 10, 2025 13:37
3f3e276
to
e37ee13
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:skip
This commit does not require backporting
Feature:http
release_note:enhancement
Team:Core
Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
resolves #105692
This PR adds a pre response handler that sets a warning header if the requested endpoint is deprecated.
Checklist
Check the PR satisfies following conditions.
Reviewers should verify this PR satisfies this list as well.
release_note:breaking
label should be applied in these situations.release_note:*
label is applied per the guidelinesIdentify risks
Does this PR introduce any risks? For example, consider risks like hard to test bugs, performance regression, potential of data loss.
Describe the risk, its severity, and mitigation for each identified risk. Invite stakeholders and evaluate how to proceed before merging.