Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Kbn team 1309 relocate 20241223085057 #205077

Draft
wants to merge 17 commits into
base: main
Choose a base branch
from
Draft

Kbn team 1309 relocate 20241223085057 #205077

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
0440509
Relocate @kbn/core inside src/core/packages/core
gsoldevila Dec 20, 2024
9e4aa3d
Remove unexisting paths
gsoldevila Dec 20, 2024
1fb6c1b
Add `test-helpers` as dev code in ESLint exceptions
gsoldevila Dec 20, 2024
0155404
Update outdated scss files
gsoldevila Dec 20, 2024
9dbc070
Fix @kbn/core location in optimizer
gsoldevila Dec 20, 2024
d7e122e
Now that's a brittle test!
gsoldevila Dec 20, 2024
c43dc8b
Relocating module `@kbn/core-analytics-browser`
gsoldevila Dec 23, 2024
6d13d03
Relocating module `@kbn/core-analytics-browser-internal`
gsoldevila Dec 23, 2024
065f1ce
Relocating module `@kbn/core-analytics-server`
gsoldevila Dec 23, 2024
3ee2ae0
Relocating module `@kbn/core-analytics-server-internal`
gsoldevila Dec 23, 2024
8e4d6de
Relocating module `@kbn/core-application-browser`
gsoldevila Dec 23, 2024
dfacdbc
Relocating module `@kbn/core-application-browser-internal`
gsoldevila Dec 23, 2024
88ff532
Relocating module `@kbn/core-application-common`
gsoldevila Dec 23, 2024
e505c4e
Relocating module `@kbn/core-apps-browser-internal`
gsoldevila Dec 23, 2024
102b17d
Relocating module `@kbn/core-apps-server-internal`
gsoldevila Dec 23, 2024
2739513
Relocating module `@kbn/core-base-browser-internal`
gsoldevila Dec 23, 2024
c9d1a2f
Relocating module `@kbn/core-base-common`
gsoldevila Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Relocating module @kbn/core-application-common
  • Loading branch information
@gsoldevila
gsoldevila committed Dec 23, 2024
commit 88ff532f2ff5b146c2bb051122d8ffb2d785f5c7
2 changes: 1 addition & 1 deletion .github/CODEOWNERS
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,6 @@ packages/content-management/user_profiles @elastic/appex-sharedux
packages/core/analytics/core-analytics-browser-mocks @elastic/kibana-core
packages/core/analytics/core-analytics-server-mocks @elastic/kibana-core
packages/core/application/core-application-browser-mocks @elastic/kibana-core
packages/core/application/core-application-common @elastic/kibana-core
packages/core/apps/core-apps-browser-internal @elastic/kibana-core
packages/core/apps/core-apps-browser-mocks @elastic/kibana-core
packages/core/apps/core-apps-server-internal @elastic/kibana-core
Expand Down Expand Up @@ -557,6 +556,7 @@ src/core/packages/analytics/server @elastic/kibana-core
src/core/packages/analytics/server-internal @elastic/kibana-core
src/core/packages/application/browser @elastic/kibana-core
src/core/packages/application/browser-internal @elastic/kibana-core
src/core/packages/application/common @elastic/kibana-core
src/core/packages/core @elastic/kibana-core
src/platform/packages/private/default-nav/devtools @elastic/kibana-management
src/platform/packages/private/default-nav/management @elastic/kibana-management
Expand Down
2 changes: 1 addition & 1 deletion docs/developer/architecture/security/feature-registration.asciidoc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@ Registering a feature consists of the following fields. For more information, co
|A human readable name for your feature.

|`category` (required)
|{kib-repo}blob/{branch}/packages/core/application/core-application-common/src/app_category.ts[`AppCategory`]
|{kib-repo}blob/{branch}/src/core/packages/application/common/src/app_category.ts[`AppCategory`]
|`DEFAULT_APP_CATEGORIES.kibana`
|The `AppCategory` which best represents your feature. Used to organize the display
of features within the management screens.
Expand Down
2 changes: 1 addition & 1 deletion package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,7 +252,7 @@
"@kbn/core-app-status-plugin": "link:test/plugin_functional/plugins/core_app_status",
"@kbn/core-application-browser": "link:src/core/packages/application/browser",
"@kbn/core-application-browser-internal": "link:src/core/packages/application/browser-internal",
"@kbn/core-application-common": "link:packages/core/application/core-application-common",
"@kbn/core-application-common": "link:src/core/packages/application/common",
"@kbn/core-apps-browser-internal": "link:packages/core/apps/core-apps-browser-internal",
"@kbn/core-apps-server-internal": "link:packages/core/apps/core-apps-server-internal",
"@kbn/core-base-browser-internal": "link:packages/core/base/core-base-browser-internal",
Expand Down
0 ...ication/core-application-common/README.md → ...ore/packages/application/common/README.md
View file
Open in desktop
File renamed without changes.
0 ...lication/core-application-common/index.ts → ...core/packages/application/common/index.ts
View file
Open in desktop
File renamed without changes.
4 changes: 2 additions & 2 deletions ...on/core-application-common/jest.config.js → ...ackages/application/common/jest.config.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,6 @@

module.exports = {
preset: '@kbn/test',
rootDir: '../../../..',
roots: ['<rootDir>/packages/core/application/core-application-common'],
rootDir: '../../../../..',
roots: ['<rootDir>/src/core/packages/application/common'],
};
0 ...tion/core-application-common/kibana.jsonc → .../packages/application/common/kibana.jsonc
View file
Open in desktop
File renamed without changes.
0 ...tion/core-application-common/package.json → .../packages/application/common/package.json
View file
Open in desktop
File renamed without changes.
0 ...re-application-common/src/app_category.ts → ...es/application/common/src/app_category.ts
View file
Open in desktop
File renamed without changes.
0 ...plication-common/src/app_wrapper_class.ts → ...plication/common/src/app_wrapper_class.ts
View file
Open in desktop
File renamed without changes.
0 ...tion-common/src/default_app_categories.ts → ...tion/common/src/default_app_categories.ts
View file
Open in desktop
File renamed without changes.
0 ...plication-common/src/global_app_style.tsx → ...plication/common/src/global_app_style.tsx
View file
Open in desktop
File renamed without changes.
2 changes: 1 addition & 1 deletion ...ion/core-application-common/tsconfig.json → ...packages/application/common/tsconfig.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": "../../../../tsconfig.base.json",
"extends": "../../../../../tsconfig.base.json",
"compilerOptions": {
"outDir": "target/types",
"types": [
Expand Down
4 changes: 2 additions & 2 deletions tsconfig.base.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -252,8 +252,8 @@
"@kbn/core-application-browser-internal/*": ["src/core/packages/application/browser-internal/*"],
"@kbn/core-application-browser-mocks": ["packages/core/application/core-application-browser-mocks"],
"@kbn/core-application-browser-mocks/*": ["packages/core/application/core-application-browser-mocks/*"],
"@kbn/core-application-common": ["packages/core/application/core-application-common"],
"@kbn/core-application-common/*": ["packages/core/application/core-application-common/*"],
"@kbn/core-application-common": ["src/core/packages/application/common"],
"@kbn/core-application-common/*": ["src/core/packages/application/common/*"],
"@kbn/core-apps-browser-internal": ["packages/core/apps/core-apps-browser-internal"],
"@kbn/core-apps-browser-internal/*": ["packages/core/apps/core-apps-browser-internal/*"],
"@kbn/core-apps-browser-mocks": ["packages/core/apps/core-apps-browser-mocks"],
Expand Down
2 changes: 1 addition & 1 deletion yarn.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4317,7 +4317,7 @@
version "0.0.0"
uid ""

"@kbn/core-application-common@link:packages/core/application/core-application-common":
"@kbn/core-application-common@link:src/core/packages/application/common":
version "0.0.0"
uid ""

Expand Down