[ES|QL] Improve STATS command summary extraction
#199796
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vadimkibana
added
review
release_note:skip
|
Pinging @elastic/kibana-esql (Team:ESQL) |
💚 Build Succeeded
Metrics [docs]Page load bundle
|
stratoula
reviewed
Nov 13, 2024
| const summary = mutate.commands.stats.summarize(query); | ||
|
|
||
| console.log(summary.newFields); // [ 'a', '`agg(c)`' ] | ||
| console.log(summary.usedFields); // [ 'b', 'c', 'd' ] |
stratoula
approved these changes
Nov 13, 2024
|
Starting backport for target branches: 8.x |
💔 All backports failedManual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
vadimkibana
added a commit
to vadimkibana/kibana
that referenced
this pull request
Nov 13, 2024
## Summary Partially addresses elastic#191812 - Correctly extracts summary from of fields from the `BY` clause of `STATS` command. - The `.summarize()` command now returns `newFields` and `usedFields` properties. The `newFields` is a list of newly created fields by the `STATS` command. The `usedFields` is a list of all fields which were used by the `STATS` command. - Improves parameter node handling. ### Example Extract all "new" and "used" fields from all `STATS` commands: ```ts const query = EsqlQuery.fromSrc('FROM index | STATS a = max(b), agg(c) BY d'); const summary = mutate.commands.stats.summarize(query); console.log(summary.newFields); // [ 'a', '`agg(c)`' ] console.log(summary.usedFields); // [ 'b', 'c', 'd' ] ``` ### Checklist Delete any items that are not applicable to this PR. - [x] [Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html) was added for features that require explanation or tutorials - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#_add_your_labels) (cherry picked from commit d276b48) # Conflicts: # packages/kbn-esql-ast/src/mutate/commands/stats/index.test.ts # packages/kbn-esql-ast/src/mutate/commands/stats/index.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Partially addresses #191812
BYclause ofSTATScommand..summarize()command now returnsnewFieldsandusedFieldsproperties. ThenewFieldsis a list of newly created fields by theSTATScommand. TheusedFieldsis a list of all fields which were used by theSTATScommand.Example
Extract all "new" and "used" fields from all
STATScommands:Checklist
Delete any items that are not applicable to this PR.
For maintainers