[ML] Anomaly detection: Adds spacer below split card chart in job wizard #199708
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jgowdyelastic
added
release_note:enhancement
:ml
Feature:Anomaly Detection
|
Pinging @elastic/ml-ui (:ml) |
peteharverson
changed the title
💚 Build Succeeded
Metrics [docs]Async chunks
History
|
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Nov 12, 2024
…ard (elastic#199708) Adds a spacer below the chart so the `Add metric` label doesn't appear like it is underneath the cards due to their drop shadow. Recommend viewing the diff with whitespace hidden as the change looks larger than it actually is. <img width="1064" alt="image" src="https://github.com/user-attachments/assets/90e460c4-5ad6-4f4b-bf9f-7163d740747f"> vs <img width="1057" alt="image" src="https://github.com/user-attachments/assets/bb8d7bc3-17bb-428d-a8a4-c515a5845025"> (cherry picked from commit c58989c)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Nov 12, 2024
…ob wizard (#199708) (#199822) # Backport This will backport the following commits from `main` to `8.x`: - [[ML] Anomaly detection: Adds spacer below split card chart in job wizard (#199708)](#199708) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"James Gowdy","email":"jgowdy@elastic.co"},"sourceCommit":{"committedDate":"2024-11-12T16:13:29Z","message":"[ML] Anomaly detection: Adds spacer below split card chart in job wizard (#199708)\n\nAdds a spacer below the chart so the `Add metric` label doesn't appear\r\nlike it is underneath the cards due to their drop shadow.\r\n\r\nRecommend viewing the diff with whitespace hidden as the change looks\r\nlarger than it actually is.\r\n\r\n<img width=\"1064\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/90e460c4-5ad6-4f4b-bf9f-7163d740747f\">\r\n\r\nvs \r\n\r\n<img width=\"1057\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/bb8d7bc3-17bb-428d-a8a4-c515a5845025\">","sha":"c58989c41976c50ae097fbca92b4c3b9076c3301","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:enhancement",":ml","Feature:Anomaly Detection","v9.0.0","backport:version","v8.17.0"],"title":"[ML] Anomaly detection: Adds spacer below split card chart in job wizard","number":199708,"url":"https://github.com/elastic/kibana/pull/199708","mergeCommit":{"message":"[ML] Anomaly detection: Adds spacer below split card chart in job wizard (#199708)\n\nAdds a spacer below the chart so the `Add metric` label doesn't appear\r\nlike it is underneath the cards due to their drop shadow.\r\n\r\nRecommend viewing the diff with whitespace hidden as the change looks\r\nlarger than it actually is.\r\n\r\n<img width=\"1064\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/90e460c4-5ad6-4f4b-bf9f-7163d740747f\">\r\n\r\nvs \r\n\r\n<img width=\"1057\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/bb8d7bc3-17bb-428d-a8a4-c515a5845025\">","sha":"c58989c41976c50ae097fbca92b4c3b9076c3301"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/199708","number":199708,"mergeCommit":{"message":"[ML] Anomaly detection: Adds spacer below split card chart in job wizard (#199708)\n\nAdds a spacer below the chart so the `Add metric` label doesn't appear\r\nlike it is underneath the cards due to their drop shadow.\r\n\r\nRecommend viewing the diff with whitespace hidden as the change looks\r\nlarger than it actually is.\r\n\r\n<img width=\"1064\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/90e460c4-5ad6-4f4b-bf9f-7163d740747f\">\r\n\r\nvs \r\n\r\n<img width=\"1057\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/bb8d7bc3-17bb-428d-a8a4-c515a5845025\">","sha":"c58989c41976c50ae097fbca92b4c3b9076c3301"}},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: James Gowdy <jgowdy@elastic.co>
tkajtoch
pushed a commit
to tkajtoch/kibana
that referenced
this pull request
Nov 12, 2024
…ard (elastic#199708) Adds a spacer below the chart so the `Add metric` label doesn't appear like it is underneath the cards due to their drop shadow. Recommend viewing the diff with whitespace hidden as the change looks larger than it actually is. <img width="1064" alt="image" src="https://github.com/user-attachments/assets/90e460c4-5ad6-4f4b-bf9f-7163d740747f"> vs <img width="1057" alt="image" src="https://github.com/user-attachments/assets/bb8d7bc3-17bb-428d-a8a4-c515a5845025">
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds a spacer below the chart so the
Add metriclabel doesn't appear like it is underneath the cards due to their drop shadow.Recommend viewing the diff with whitespace hidden as the change looks larger than it actually is.
vs