[Entity Analytics] [Entity Store] Refactor entity store enablement (server side) #199638
+664
−4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiansivive
added
technical debt
tiansivive
commented
Nov 12, 2024
| return { engines, succeeded: true }; | ||
| } | ||
|
|
||
| public async status(): Promise<GetEntityStoreStatusResponse> { |
There was a problem hiding this comment.
Is this the correct way to compute the status?
What should we do in those "in between" states, where, for example, not all engines are stopped?
Maybe worry about it later if we ever decide allowing individual engine setup?
|
Pinging @elastic/security-entity-analytics (Team:Entity Analytics) |
💔 Build Failed
Failed CI StepsHistory
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds 2 new endpoints regarding enablement of the Entity Store:
api/entity_store/enable, which initializes entity engines for bothuserandhostentitiesapi/entity_store/status, which computes a global store status based on the individual engine statusIn addition, running initialization of multiple engines in parallel is now allowed.
How to test
POST kbn:/api/entity_store/enableinstallingby callingGET kbn:/api/entity_store/statusstatusendpoint. Once initialization finishes, the status should switch torunning