-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dashboard Usability] Remove borders from presentation panel and CSS clean up for hover actions #198454
Merged
cqliu1
merged 25 commits into
elastic:main
from
cqliu1:dashboard/hover-actions-style-cleanup
Nov 13, 2024
+165
−243
Merged
[Dashboard Usability] Remove borders from presentation panel and CSS clean up for hover actions #198454
Changes from 20 commits
Commits
Show all changes
25 commits
Select commit
Hold shift + click to select a range
3ba63da
Fix border styles in dashboard
cqliu1 a22965f
Move border styles into presentation panel
cqliu1 4f0b522
Delete unused CSS
cqliu1 c72ef4c
More cleanup
cqliu1 f5f6fbe
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine ac03c42
Remove conflicting styles in solutions
cqliu1 f4ae6de
Fix emotion
cqliu1 ed0b4fc
Merge branch 'main' of https://github.com/elastic/kibana into dashboa…
cqliu1 9420aea
Fix hover actions check
cqliu1 db2e564
Only show panel border on hover if hover actions are available
cqliu1 d89fdde
Merge branch 'main' of https://github.com/elastic/kibana into dashboa…
cqliu1 0146c38
Add comments
cqliu1 ff5237d
Fix z-index on hover actions hover
cqliu1 3c57f94
Fix hover actions getting cut off
cqliu1 5360032
Fix outlines on hover with margins on and off
cqliu1 32d978b
Move hover actions styles to emotion
cqliu1 945ccd5
Remove unused imports
cqliu1 57399c7
Merge branch 'main' of https://github.com/elastic/kibana into dashboa…
cqliu1 1b38329
Update presentation_panel_hover_actions.tsx
cqliu1 e75da38
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine ed9869c
Fix whitespace
cqliu1 acff0b1
Merge branch 'main' of https://github.com/elastic/kibana into dashboa…
cqliu1 4b5535a
Change hover border selectors
cqliu1 397b828
Merge branch 'main' of https://github.com/elastic/kibana into dashboa…
cqliu1 bff6474
Merge branch 'main' into dashboard/hover-actions-style-cleanup
cqliu1 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
39 changes: 3 additions & 36 deletions
39
src/plugins/dashboard/public/dashboard_container/component/grid/_dashboard_panel.scss
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is adds space between controls and the dashboard grid when margins are off.