-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Onboarding] Better onboarding copy #196895
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor copyedits for clarity, consistency, and concision. (CCCC 😄 )
x-pack/plugins/search_indices/public/code_examples/constants.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/search_indices/public/code_examples/constants.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/search_indices/public/code_examples/ingest_data.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/search_indices/public/code_examples/constants.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/search_indices/public/code_examples/ingest_data.ts
Outdated
Show resolved
Hide resolved
x-pack/plugins/search_indices/public/components/index_documents/add_documents_code_example.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>
x-pack/plugins/search_indices/public/components/index_documents/add_documents_code_example.tsx
Outdated
Show resolved
Hide resolved
x-pack/plugins/search_indices/public/components/shared/code_sample.tsx
Outdated
Show resolved
Hide resolved
Starting backport for target branches: 8.x |
💚 Build Succeeded
Metrics [docs]Async chunks
|
## Summary Improved onboarding copy <img width="1433" alt="image" src="https://github.com/user-attachments/assets/b25b7677-8acc-4875-b775-5276956ba69b"> --------- Co-authored-by: Michael DeFazio <michael.defazio@elastic.co> Co-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com> (cherry picked from commit 5aad976)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
# Backport This will backport the following commits from `main` to `8.x`: - [[Onboarding] Better onboarding copy (#196895)](#196895) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Joe McElroy","email":"joseph.mcelroy@elastic.co"},"sourceCommit":{"committedDate":"2024-10-18T18:03:51Z","message":"[Onboarding] Better onboarding copy (#196895)\n\n## Summary\r\n\r\nImproved onboarding copy\r\n\r\n<img width=\"1433\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/b25b7677-8acc-4875-b775-5276956ba69b\">\r\n\r\n---------\r\n\r\nCo-authored-by: Michael DeFazio <michael.defazio@elastic.co>\r\nCo-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>","sha":"5aad97651dba2fd0049f1599a78aa84d39403526","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","Team:Search","backport:prev-minor"],"title":"[Onboarding] Better onboarding copy","number":196895,"url":"https://github.com/elastic/kibana/pull/196895","mergeCommit":{"message":"[Onboarding] Better onboarding copy (#196895)\n\n## Summary\r\n\r\nImproved onboarding copy\r\n\r\n<img width=\"1433\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/b25b7677-8acc-4875-b775-5276956ba69b\">\r\n\r\n---------\r\n\r\nCo-authored-by: Michael DeFazio <michael.defazio@elastic.co>\r\nCo-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>","sha":"5aad97651dba2fd0049f1599a78aa84d39403526"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196895","number":196895,"mergeCommit":{"message":"[Onboarding] Better onboarding copy (#196895)\n\n## Summary\r\n\r\nImproved onboarding copy\r\n\r\n<img width=\"1433\" alt=\"image\"\r\nsrc=\"https://github.com/user-attachments/assets/b25b7677-8acc-4875-b775-5276956ba69b\">\r\n\r\n---------\r\n\r\nCo-authored-by: Michael DeFazio <michael.defazio@elastic.co>\r\nCo-authored-by: Liam Thompson <32779855+leemthompo@users.noreply.github.com>","sha":"5aad97651dba2fd0049f1599a78aa84d39403526"}}]}] BACKPORT--> Co-authored-by: Joe McElroy <joseph.mcelroy@elastic.co>
Summary
Improved onboarding copy