Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ip location processor] Add mmdb suffix to db file names #196788

Merged
merged 3 commits into from
Oct 18, 2024

Conversation

mattkime
Copy link
Contributor

@mattkime mattkime commented Oct 18, 2024

Summary

Simply adds the mmdb suffix to the db names.

Closes #196745

@mattkime mattkime self-assigned this Oct 18, 2024
@mattkime mattkime added Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more Feature:Ingest Node Pipelines Ingest node pipelines management backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 18, 2024
@mattkime mattkime changed the title add suffix to database names [ip location processor] add mmdb suffix to db file names Oct 18, 2024
@mattkime mattkime marked this pull request as ready for review October 18, 2024 12:50
@mattkime mattkime requested a review from a team as a code owner October 18, 2024 12:50
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-management (Team:Kibana Management)

@mattkime mattkime added the release_note:skip Skip the PR/issue when compiling release notes label Oct 18, 2024
@mattkime mattkime changed the title [ip location processor] add mmdb suffix to db file names [ip location processor] Add mmdb suffix to db file names Oct 18, 2024
Copy link
Contributor

@ElenaStoeva ElenaStoeva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes lgtm, tested locally 👍

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
ingestPipelines 392.6KB 392.7KB +67.0B

History

cc @mattkime

@mattkime mattkime added v9.0.0 v8.16.0 v8.17.0 backport:version Backport to applied version labels labels Oct 18, 2024
@mattkime mattkime merged commit f789ba6 into elastic:main Oct 18, 2024
35 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11409309334

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 18, 2024
)

## Summary

Simply adds the mmdb suffix to the db names.

Closes elastic#196745

(cherry picked from commit f789ba6)
kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 18, 2024
)

## Summary

Simply adds the mmdb suffix to the db names.

Closes elastic#196745

(cherry picked from commit f789ba6)
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.16
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 18, 2024
…) (#196941)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[ip location processor] Add mmdb suffix to db file names
(#196788)](#196788)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Matthew
Kime","email":"matt@mattki.me"},"sourceCommit":{"committedDate":"2024-10-18T18:48:57Z","message":"[ip
location processor] Add mmdb suffix to db file names (#196788)\n\n##
Summary\r\n\r\nSimply adds the mmdb suffix to the db
names.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/196745","sha":"f789ba61d4ca675bf6ea35f4c1f5fb033363e06a","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana
Management","release_note:skip","v9.0.0","Feature:Ingest Node
Pipelines","backport:prev-minor","v8.16.0","backport:version","v8.17.0"],"title":"[ip
location processor] Add mmdb suffix to db file
names","number":196788,"url":"https://github.com/elastic/kibana/pull/196788","mergeCommit":{"message":"[ip
location processor] Add mmdb suffix to db file names (#196788)\n\n##
Summary\r\n\r\nSimply adds the mmdb suffix to the db
names.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/196745","sha":"f789ba61d4ca675bf6ea35f4c1f5fb033363e06a"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196788","number":196788,"mergeCommit":{"message":"[ip
location processor] Add mmdb suffix to db file names (#196788)\n\n##
Summary\r\n\r\nSimply adds the mmdb suffix to the db
names.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/196745","sha":"f789ba61d4ca675bf6ea35f4c1f5fb033363e06a"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Matthew Kime <matt@mattki.me>
kibanamachine added a commit that referenced this pull request Oct 18, 2024
) (#196940)

# Backport

This will backport the following commits from `main` to `8.16`:
- [[ip location processor] Add mmdb suffix to db file names
(#196788)](#196788)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Matthew
Kime","email":"matt@mattki.me"},"sourceCommit":{"committedDate":"2024-10-18T18:48:57Z","message":"[ip
location processor] Add mmdb suffix to db file names (#196788)\n\n##
Summary\r\n\r\nSimply adds the mmdb suffix to the db
names.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/196745","sha":"f789ba61d4ca675bf6ea35f4c1f5fb033363e06a","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Kibana
Management","release_note:skip","v9.0.0","Feature:Ingest Node
Pipelines","backport:prev-minor","v8.16.0","backport:version","v8.17.0"],"title":"[ip
location processor] Add mmdb suffix to db file
names","number":196788,"url":"https://github.com/elastic/kibana/pull/196788","mergeCommit":{"message":"[ip
location processor] Add mmdb suffix to db file names (#196788)\n\n##
Summary\r\n\r\nSimply adds the mmdb suffix to the db
names.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/196745","sha":"f789ba61d4ca675bf6ea35f4c1f5fb033363e06a"}},"sourceBranch":"main","suggestedTargetBranches":["8.16","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196788","number":196788,"mergeCommit":{"message":"[ip
location processor] Add mmdb suffix to db file names (#196788)\n\n##
Summary\r\n\r\nSimply adds the mmdb suffix to the db
names.\r\n\r\nCloses
https://github.com/elastic/kibana/issues/196745","sha":"f789ba61d4ca675bf6ea35f4c1f5fb033363e06a"}},{"branch":"8.16","label":"v8.16.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.17.0","branchLabelMappingKey":"^v8.17.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Matthew Kime <matt@mattki.me>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) backport:version Backport to applied version labels Feature:Ingest Node Pipelines Ingest node pipelines management release_note:skip Skip the PR/issue when compiling release notes Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more v8.16.0 v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Ingest Pipelines] Database file should include .mmdb extension
4 participants