Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Inventory] Adding initial e2e structure #196560

Merged
merged 10 commits into from
Oct 17, 2024

Conversation

cauemarcondes
Copy link
Contributor

@cauemarcondes cauemarcondes commented Oct 16, 2024

closes #193992

How to open cypress dashboard locally:

node x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js --open            

How to run cypress tests:

node x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js

How to run cypress tests multiple times:

node x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js --server
node x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js --runner --times=X

@cauemarcondes cauemarcondes added release_note:skip Skip the PR/issue when compiling release notes backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v8.16.0 labels Oct 16, 2024
@cauemarcondes cauemarcondes requested review from a team as code owners October 16, 2024 14:56
@botelastic botelastic bot added ci:project-deploy-observability Create an Observability project Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team labels Oct 16, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services)

Copy link
Contributor

@rmyz rmyz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@kpatticha kpatticha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code LGTM. Thanks for your efforts to add the tests

I think we can close this one #193992

@kibanamachine
Copy link
Contributor

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7164

[✅] Inventory - Cypress: 50/50 tests passed.

see run history

@cauemarcondes cauemarcondes enabled auto-merge (squash) October 17, 2024 13:02
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 17, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: b143d6b
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-196560-b143d6b433c2

Metrics [docs]

Public APIs missing comments

Total count of every public API that lacks a comment. Target amount is 0. Run node scripts/build_api_docs --plugin [yourplugin] --stats comments for more detailed information.

id before after diff
@kbn/apm-synthtrace 72 83 +11

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
inventory 218.5KB 218.6KB +92.0B
Unknown metric groups

API count

id before after diff
@kbn/apm-synthtrace 72 83 +11

ESLint disabled in files

id before after diff
inventory 3 4 +1

ESLint disabled line counts

id before after diff
@kbn/inventory-e2e - 3 +3

Total ESLint disabled count

id before after diff
@kbn/inventory-e2e - 3 +3
inventory 3 4 +1
total +4

History

@cauemarcondes cauemarcondes merged commit 3bfa7c0 into elastic:main Oct 17, 2024
44 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.16, 8.x

https://github.com/elastic/kibana/actions/runs/11386355094

@kibanamachine
Copy link
Contributor

💔 All backports failed

Status Branch Result
8.16 Backport failed because of merge conflicts
8.x Backport failed because of merge conflicts

You might need to backport the following PRs to 8.x:
- [Synthtrace] Adding Entities support (#196258)

Manual backport

To create the backport manually run:

node scripts/backport --pr 196560

Questions ?

Please refer to the Backport tool documentation

@cauemarcondes cauemarcondes deleted the inventory-e2e branch October 17, 2024 14:59
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Oct 17, 2024
closes elastic#193992

How to open cypress dashboard locally:
```
node x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js --open
```

How to run cypress tests:
```
node x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js
```

How to run cypress tests multiple times:
```
node x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js --server
node x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js --runner --times=X
```

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 3bfa7c0)

# Conflicts:
#	.github/CODEOWNERS
#	packages/kbn-apm-synthtrace-client/src/lib/entities/container_entity.ts
#	packages/kbn-apm-synthtrace-client/src/lib/entities/host_entity.ts
#	packages/kbn-apm-synthtrace-client/src/lib/entities/service_entity.ts
#	packages/kbn-apm-synthtrace/index.ts
#	packages/kbn-apm-synthtrace/src/cli/scenario.ts
#	packages/kbn-apm-synthtrace/src/lib/entities/entities_synthtrace_es_client.ts
#	packages/kbn-apm-synthtrace/src/lib/entities/entities_synthtrace_kibana_client.ts
#	packages/kbn-spec-to-console/lib/convert/parts.js
cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Oct 17, 2024
closes elastic#193992

How to open cypress dashboard locally:
```
node x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js --open
```

How to run cypress tests:
```
node x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js
```

How to run cypress tests multiple times:
```
node x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js --server
node x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js --runner --times=X
```

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 3bfa7c0)

# Conflicts:
#	.github/CODEOWNERS
#	packages/kbn-apm-synthtrace-client/src/lib/entities/container_entity.ts
#	packages/kbn-apm-synthtrace-client/src/lib/entities/host_entity.ts
#	packages/kbn-apm-synthtrace-client/src/lib/entities/service_entity.ts
#	packages/kbn-apm-synthtrace/index.ts
#	packages/kbn-apm-synthtrace/src/cli/scenario.ts
#	packages/kbn-apm-synthtrace/src/lib/entities/entities_synthtrace_es_client.ts
#	packages/kbn-apm-synthtrace/src/lib/entities/entities_synthtrace_kibana_client.ts
#	packages/kbn-spec-to-console/lib/convert/parts.js
@cauemarcondes
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x
8.16

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@cauemarcondes
Copy link
Contributor Author

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

cauemarcondes added a commit to cauemarcondes/kibana that referenced this pull request Oct 18, 2024
closes elastic#193992

How to open cypress dashboard locally:
```
node x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js --open
```

How to run cypress tests:
```
node x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js
```

How to run cypress tests multiple times:
```
node x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js --server
node x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js --runner --times=X
```

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
(cherry picked from commit 3bfa7c0)

# Conflicts:
#	.github/CODEOWNERS
cauemarcondes added a commit that referenced this pull request Oct 18, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Inventory] Adding initial e2e structure
(#196560)](#196560)

<!--- Backport version: 8.9.8 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Cauê
Marcondes","email":"55978943+cauemarcondes@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-17T13:50:11Z","message":"[Inventory]
Adding initial e2e structure (#196560)\n\ncloses
https://github.com/elastic/kibana/issues/193992\r\n\r\nHow to open
cypress dashboard locally:\r\n```\r\nnode
x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js
--open \r\n```\r\n\r\nHow to run cypress tests:\r\n```\r\nnode
x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js\r\n```\r\n\r\nHow
to run cypress tests multiple times:\r\n```\r\nnode
x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js
--server\r\nnode
x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js
--runner --times=X\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3bfa7c00181599541c924d36b593205fd5d9fed4","branchLabelMapping":{"^v9.0.0$":"main","^v8.17.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-infra_services","v8.16.0"],"number":196560,"url":"https://github.com/elastic/kibana/pull/196560","mergeCommit":{"message":"[Inventory]
Adding initial e2e structure (#196560)\n\ncloses
https://github.com/elastic/kibana/issues/193992\r\n\r\nHow to open
cypress dashboard locally:\r\n```\r\nnode
x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js
--open \r\n```\r\n\r\nHow to run cypress tests:\r\n```\r\nnode
x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js\r\n```\r\n\r\nHow
to run cypress tests multiple times:\r\n```\r\nnode
x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js
--server\r\nnode
x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js
--runner --times=X\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3bfa7c00181599541c924d36b593205fd5d9fed4"}},"sourceBranch":"main","suggestedTargetBranches":["8.16"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196560","number":196560,"mergeCommit":{"message":"[Inventory]
Adding initial e2e structure (#196560)\n\ncloses
https://github.com/elastic/kibana/issues/193992\r\n\r\nHow to open
cypress dashboard locally:\r\n```\r\nnode
x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js
--open \r\n```\r\n\r\nHow to run cypress tests:\r\n```\r\nnode
x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js\r\n```\r\n\r\nHow
to run cypress tests multiple times:\r\n```\r\nnode
x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js
--server\r\nnode
x-pack/plugins/observability_solution/inventory/scripts/test/e2e.js
--runner --times=X\r\n```\r\n\r\n---------\r\n\r\nCo-authored-by:
kibanamachine
<42973632+kibanamachine@users.noreply.github.com>","sha":"3bfa7c00181599541c924d36b593205fd5d9fed4"}},{"branch":"8.16","label":"v8.16.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

---------

Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-infra_services Observability Infrastructure & Services User Experience Team v8.17.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Inventory] Add tests
7 participants