Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dataset Quality] Hide unreachable links #196302

Conversation

mohamedhamed-ahmed
Copy link
Contributor

@mohamedhamed-ahmed mohamedhamed-ahmed commented Oct 15, 2024

closes #196256

links.mov

@mohamedhamed-ahmed mohamedhamed-ahmed added Team:obs-ux-logs Observability Logs User Experience Team backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes bug Fixes for quality problems that affect the customer experience labels Oct 15, 2024
@mohamedhamed-ahmed mohamedhamed-ahmed marked this pull request as ready for review October 15, 2024 15:10
@mohamedhamed-ahmed mohamedhamed-ahmed requested a review from a team as a code owner October 15, 2024 15:10
@elasticmachine
Copy link
Contributor

Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs)

@mohamedhamed-ahmed mohamedhamed-ahmed changed the title [Dataset Quality] Remove unreachable links [Dataset Quality] Hide unreachable links Oct 15, 2024
@botelastic botelastic bot added the ci:project-deploy-observability Create an Observability project label Oct 15, 2024
Copy link
Contributor

@yngrdyn yngrdyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 15, 2024

💚 Build Succeeded

  • Buildkite Build
  • Commit: dc7afe6
  • Kibana Serverless Image: docker.elastic.co/kibana-ci/kibana-serverless:pr-196302-dc7afe6535ea

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
observabilityLogsExplorer 147.3KB 147.3KB +22.0B
unifiedDocViewer 125.9KB 126.0KB +10.0B
total +32.0B

History

@mohamedhamed-ahmed mohamedhamed-ahmed merged commit 5fbec1f into elastic:main Oct 15, 2024
30 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11355121410

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 15, 2024
# Backport

This will backport the following commits from `main` to `8.x`:
- [[Dataset Quality] Hide unreachable links
(#196302)](#196302)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT
[{"author":{"name":"mohamedhamed-ahmed","email":"mohamed.ahmed@elastic.co"},"sourceCommit":{"committedDate":"2024-10-15T22:07:38Z","message":"[Dataset
Quality] Hide unreachable links (#196302)\n\ncloses
https://github.com/elastic/kibana/issues/196256\r\n\r\n\r\nhttps://github.com/user-attachments/assets/5cec1296-a17a-43bb-8530-99e7261a189a","sha":"5fbec1febc0050b2faaba7a25cf4aba9bf0cea1f","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","backport:prev-minor","ci:project-deploy-observability","Team:obs-ux-logs"],"title":"[Dataset
Quality] Hide unreachable
links","number":196302,"url":"https://github.com/elastic/kibana/pull/196302","mergeCommit":{"message":"[Dataset
Quality] Hide unreachable links (#196302)\n\ncloses
https://github.com/elastic/kibana/issues/196256\r\n\r\n\r\nhttps://github.com/user-attachments/assets/5cec1296-a17a-43bb-8530-99e7261a189a","sha":"5fbec1febc0050b2faaba7a25cf4aba9bf0cea1f"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/196302","number":196302,"mergeCommit":{"message":"[Dataset
Quality] Hide unreachable links (#196302)\n\ncloses
https://github.com/elastic/kibana/issues/196256\r\n\r\n\r\nhttps://github.com/user-attachments/assets/5cec1296-a17a-43bb-8530-99e7261a189a","sha":"5fbec1febc0050b2faaba7a25cf4aba9bf0cea1f"}}]}]
BACKPORT-->

Co-authored-by: mohamedhamed-ahmed <mohamed.ahmed@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience ci:project-deploy-observability Create an Observability project release_note:skip Skip the PR/issue when compiling release notes Team:obs-ux-logs Observability Logs User Experience Team v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Dataset Quality] 🐞 Remove unreachable links
4 participants