Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cloud Security] Handle critical errors returned from the Agentless API when creating and deleting agentless agents #195997

Open
wants to merge 8 commits into
base: main
Choose a base branch
from
Open

[Cloud Security] Handle critical errors returned from the Agentless API when creating and deleting agentless agents #195997

wants to merge 8 commits into from
+857 −135

Conversation

seanrathier
Copy link
Contributor

@seanrathier seanrathier commented Oct 11, 2024 •
edited
Loading

Summary

We are adding more defined error handling on the statuses returned from the Agentless API. This includes some changes to the data and messages being logged and the error that is thrown to the user.

We've also refactored the code to have the agentless agent create and delete actions share the same handling function.

Checklist

Delete any items that are not applicable to this PR.

@seanrathier seanrathier force-pushed the 10657-agentless-handle-critical-error-statuses branch from ed2b902 to 917cec7 Compare October 17, 2024 13:25
@seanrathier seanrathier self-assigned this Oct 17, 2024
@seanrathier seanrathier requested a review from a team October 17, 2024 13:49
@seanrathier seanrathier added 8.17 candidate backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:Cloud Security Cloud Security team related ci:project-deploy-security Create a Security Serverless Project release_note:skip Skip the PR/issue when compiling release notes labels Oct 17, 2024
@seanrathier seanrathier changed the title 10657 agentless handle critical error statuses [Cloud Security] Handle critical errors returned from the Agentless API when creating and deleting agentless agents Oct 17, 2024
@seanrathier seanrathier marked this pull request as ready for review October 17, 2024 20:43
@seanrathier seanrathier requested a review from a team as a code owner October 17, 2024 20:43
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

@botelastic botelastic bot added the Team:Fleet Team label for Observability Data Collection Fleet team label Oct 17, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/fleet (Team:Fleet)

juliaElastic
juliaElastic approved these changes Oct 18, 2024
View reviewed changes
Copy link
Contributor

@juliaElastic juliaElastic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seanrathier seanrathier force-pushed the 10657-agentless-handle-critical-error-statuses branch from 869782e to d8ddf42 Compare October 18, 2024 15:32
@elasticmachine
Copy link
Contributor

elasticmachine commented Oct 18, 2024 •
edited
Loading

💚 Build Succeeded

Metrics [docs]

✅ unchanged

History

cc @seanrathier

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@juliaElastic juliaElastic juliaElastic approved these changes

Assignees

@seanrathier seanrathier

Labels
8.17 candidate backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) ci:project-deploy-security Create a Security Serverless Project release_note:skip Skip the PR/issue when compiling release notes Team:Cloud Security Cloud Security team related Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@seanrathier @elasticmachine @juliaElastic