Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ES|QL] Comments inside lists #195858

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vadimkibana
Copy link
Contributor

@vadimkibana vadimkibana commented Oct 11, 2024

Summary

Partially addresses #194385

Adds support for:

  • Comment parsing inside list literals.
  • Attachment of the comments to the right list members.
  • Pretty-printing of comments inside list literals.

For example the below comments inside a list literal will be: (1) parsed out; (2) attached to the correct list members; (3) pretty printed:

ROW [
  // cmt
  /* cmt */
  /* cmt */ 1, /* cmt */ // cmt
  2,
  3
]

Checklist

Delete any items that are not applicable to this PR.

For maintainers

@vadimkibana vadimkibana added review release_note:skip Skip the PR/issue when compiling release notes v9.0.0 backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:ES|QL ES|QL related features in Kibana Team:ESQL ES|QL related features in Kibana v8.16.0 labels Oct 11, 2024
@vadimkibana vadimkibana requested a review from a team as a code owner October 11, 2024 08:07
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-esql (Team:ESQL)

Copy link
Contributor

@stratoula stratoula left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@elasticmachine
Copy link
Contributor

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
kbnUiSharedDeps-srcJs 3.4MB 3.4MB +116.0B

History

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:ES|QL ES|QL related features in Kibana release_note:skip Skip the PR/issue when compiling release notes review Team:ESQL ES|QL related features in Kibana v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants