Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ResponseOps][Cases]Design Review changes PR 3 #194936

Merged
merged 8 commits into from
Oct 8, 2024
Merged

[ResponseOps][Cases]Design Review changes PR 3 #194936

merged 8 commits into from
Oct 8, 2024

Conversation

georgianaonoleata1904
Copy link
Contributor

@georgianaonoleata1904 georgianaonoleata1904 commented Oct 4, 2024 •
edited by kibanamachine
Loading

Summary

Closes #188187

  • The fly out title now updates appropriately when editing an existing field or template, displaying "Edit field" and "Edit template" respectively.
Screen.Recording.2024-10-07.at.13.43.34.mov

@georgianaonoleata1904 georgianaonoleata1904 self-assigned this Oct 7, 2024
@georgianaonoleata1904 georgianaonoleata1904 added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) Feature:Cases Cases feature backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) v9.0.0 v8.16.0 labels Oct 7, 2024
@georgianaonoleata1904 georgianaonoleata1904 marked this pull request as ready for review October 7, 2024 10:48
@georgianaonoleata1904 georgianaonoleata1904 requested a review from a team as a code owner October 7, 2024 10:48
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 491.5KB 491.8KB +299.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @georgianaonoleata1904

@cnasikas cnasikas mentioned this pull request Oct 7, 2024
Closed
6 tasks
adcoelho
adcoelho approved these changes Oct 7, 2024
View reviewed changes
Copy link
Contributor

@adcoelho adcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it and it works as expected.

This is a super nitpick but should we have Add template in the header like the button instead of Create template?
Screenshot 2024-10-07 at 16 08 38
Screenshot 2024-10-07 at 16 08 42

For the custom fields, the header is actually Add field.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
cases 491.5KB 491.8KB +296.0B

History

cc @georgianaonoleata1904

@georgianaonoleata1904 georgianaonoleata1904 merged commit c6dd76e into elastic:main Oct 8, 2024
23 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.x

https://github.com/elastic/kibana/actions/runs/11236172334

kibanamachine pushed a commit to kibanamachine/kibana that referenced this pull request Oct 8, 2024
@georgianaonoleata1904
[ResponseOps][Cases]Design Review changes PR 3 (elastic#194936)
40f2ee5 
## Summary

Closes elastic#188187

- The fly out title now updates appropriately when editing an existing
field or template, displaying "Edit field" and "Edit template"
respectively.

https://github.com/user-attachments/assets/b85d7d27-ba89-4fbd-97c4-dc5873dda6d8
(cherry picked from commit c6dd76e)
@kibanamachine kibanamachine mentioned this pull request Oct 8, 2024
Merged
@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
✅ 8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

@kibanamachine kibanamachine mentioned this pull request Oct 8, 2024
Merged
1 task
kibanamachine added a commit that referenced this pull request Oct 8, 2024
@kibanamachine @georgianaonoleata1904
[8.x] [ResponseOps][Cases]Design Review changes PR 3 (#194936) (#195408)
0c63c08 
# Backport

This will backport the following commits from `main` to `8.x`:
- [[ResponseOps][Cases]Design Review changes PR 3
(#194936)](#194936)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Georgiana-Andreea
Onoleață","email":"georgiana.onoleata@elastic.co"},"sourceCommit":{"committedDate":"2024-10-08T13:10:24Z","message":"[ResponseOps][Cases]Design
Review changes PR 3 (#194936)\n\n## Summary\r\n\r\nCloses
#188187 \r\n\r\n- The fly out
title now updates appropriately when editing an existing\r\nfield or
template, displaying \"Edit field\" and \"Edit
template\"\r\nrespectively.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/b85d7d27-ba89-4fbd-97c4-dc5873dda6d8","sha":"c6dd76e76c4bad4c6f0a78dda86b0cc67eb31ca8","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","Team:ResponseOps","v9.0.0","Feature:Cases","backport:prev-minor","v8.16.0"],"title":"[ResponseOps][Cases]Design
Review changes PR
3","number":194936,"url":"https://github.com/elastic/kibana/pull/194936","mergeCommit":{"message":"[ResponseOps][Cases]Design
Review changes PR 3 (#194936)\n\n## Summary\r\n\r\nCloses
#188187 \r\n\r\n- The fly out
title now updates appropriately when editing an existing\r\nfield or
template, displaying \"Edit field\" and \"Edit
template\"\r\nrespectively.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/b85d7d27-ba89-4fbd-97c4-dc5873dda6d8","sha":"c6dd76e76c4bad4c6f0a78dda86b0cc67eb31ca8"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/194936","number":194936,"mergeCommit":{"message":"[ResponseOps][Cases]Design
Review changes PR 3 (#194936)\n\n## Summary\r\n\r\nCloses
#188187 \r\n\r\n- The fly out
title now updates appropriately when editing an existing\r\nfield or
template, displaying \"Edit field\" and \"Edit
template\"\r\nrespectively.\r\n\r\n\r\nhttps://github.com/user-attachments/assets/b85d7d27-ba89-4fbd-97c4-dc5873dda6d8","sha":"c6dd76e76c4bad4c6f0a78dda86b0cc67eb31ca8"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Georgiana-Andreea Onoleață <georgiana.onoleata@elastic.co>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@adcoelho adcoelho adcoelho approved these changes

@jcger jcger jcger approved these changes

@js-jankisalvi js-jankisalvi js-jankisalvi approved these changes

Assignees

@georgianaonoleata1904 georgianaonoleata1904

Labels
backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.16.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ResponseOps][Cases] Create case using templates - Design Review
7 participants
@georgianaonoleata1904 @elasticmachine @kibana-ci @kibanamachine @adcoelho @jcger @js-jankisalvi