Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Add TheHive connector to automated Observability case screenshots #193913

Open
wants to merge 11 commits into
base: main
Choose a base branch
from

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Sep 24, 2024

Summary

Relates to #180931

This PR adds TheHive connector to the automated screenshot that is used in https://www.elastic.co/docs/current/serverless/observability/case-settings#create-a-connector

The screenshot automation for that page and for https://www.elastic.co/docs/current/serverless/security/cases-settings#external-incident-management-systems had been turned off per #188997 and #189058
I could not replicate those timeout errors, but I added retry.waitFor around any clicks since that's what seems to be done in https://github.com/elastic/kibana/blob/main/x-pack/test_serverless/functional/test_suites/security/ftr/cases/configure.ts

I have also removed one of the automated screenshots that is no longer required per elastic/security-docs#5859

@lcawl lcawl added release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) docs Feature:Cases Cases feature v8.16.0 backport:version Backport to applied version labels labels Sep 24, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@lcawl lcawl marked this pull request as ready for review September 24, 2024 21:33
@lcawl lcawl requested review from a team as code owners September 24, 2024 21:33
@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops (Team:ResponseOps)

@elasticmachine
Copy link
Contributor

Pinging @elastic/response-ops-cases (Feature:Cases)

@lcawl lcawl marked this pull request as ready for review September 26, 2024 20:26
Copy link
Contributor

@adcoelho adcoelho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but maybe we dont need all the retry.waitFor? The failing tests you linked were only about common-flyout-cancel.

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:version Backport to applied version labels docs Feature:Cases Cases feature release_note:skip Skip the PR/issue when compiling release notes Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants