[8.x] [Cloud Security] [Agentless] Improving error log metadata and sending APM trace id (#192235) #193901
+275
−36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… APM trace id (elastic#192235) ## Summary This PR includes a few improvements in the communication between Kibana and the Agentless API. - Adding a `X-Request-ID` Header on all HTTP calls from the Kibana server to the Agentless API. X-Request-ID is the [currentTraceparent](https://www.elastic.co/guide/en/apm/agent/nodejs/current/agent-api.html#apm-current-traceparent) string captured from Apm Service and is unique per request. - Also, this PR enhances some error logs metadata with the relevant fields, and all documents logged to ES also includes the [trace.id](https://www.elastic.co/guide/en/ecs/8.11/ecs-tracing.html) field - Also this PR redacts the fleet token sent to the debug logs to prevent credential leaking (cherry picked from commit 10bcc62)
botelastic
bot
added
the
Team:Fleet
|
Pinging @elastic/fleet (Team:Fleet) |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
To update your PR or re-run it, just comment with: cc @opauloh |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:Questions ?
Please refer to the Backport tool documentation