[Logs Explorer] Fix Privileges Accessibility #193894
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mohamedhamed-ahmed
added
release_note:skip
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
tonyghiani
reviewed
Oct 1, 2024
x-pack/plugins/observability_solution/infra/public/apps/logs_app.tsx
Outdated
Show resolved
Hide resolved
tonyghiani
reviewed
Oct 1, 2024
x-pack/plugins/observability_solution/observability_logs_explorer/public/plugin.ts
Show resolved
Hide resolved
|
Pinging @elastic/obs-ux-logs-team (Team:obs-ux-logs) |
botelastic
bot
added
the
ci:project-deploy-observability
mohamedhamed-ahmed
added
v8.15.0
v8.16.0
backport:version
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
|
Starting backport for target branches: 8.15, 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Oct 1, 2024
closes elastic#192062 ## 📝 Summary This PR adds privileges checks for `Logs Explorerer` it checks for `Discover & Fleet` privileges before allowing the user access to `Logs Explorer`. Clicking on the `Logs` tab from the side nav defaults to `Stream`, as long as its not depricated, in case the user doesn't have access to `Logs Explorer` ## 🎥 Demo https://github.com/user-attachments/assets/a4105ec0-7681-40ee-b2fd-e39b9c178dcf (cherry picked from commit dbfd4f0)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 1, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [[Logs Explorer] Fix Privileges Accessibility (#193894)](#193894) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"mohamedhamed-ahmed","email":"mohamed.ahmed@elastic.co"},"sourceCommit":{"committedDate":"2024-10-01T11:38:16Z","message":"[Logs Explorer] Fix Privileges Accessibility (#193894)\n\ncloses https://github.com/elastic/kibana/issues/192062\r\n\r\n## 📝 Summary\r\n\r\nThis PR adds privileges checks for `Logs Explorerer` it checks for\r\n`Discover & Fleet` privileges before allowing the user access to `Logs\r\nExplorer`.\r\nClicking on the `Logs` tab from the side nav defaults to `Stream`, as\r\nlong as its not depricated, in case the user doesn't have access to\r\n`Logs Explorer`\r\n\r\n## 🎥 Demo\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/a4105ec0-7681-40ee-b2fd-e39b9c178dcf","sha":"dbfd4f0879aa89c49b379cc2c6c5feb74f5c16c7","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-logs","Team:obs-ux-infra_services","v8.15.0","v8.16.0","backport:version"],"title":"[Logs Explorer] Fix Privileges Accessibility","number":193894,"url":"https://github.com/elastic/kibana/pull/193894","mergeCommit":{"message":"[Logs Explorer] Fix Privileges Accessibility (#193894)\n\ncloses https://github.com/elastic/kibana/issues/192062\r\n\r\n## 📝 Summary\r\n\r\nThis PR adds privileges checks for `Logs Explorerer` it checks for\r\n`Discover & Fleet` privileges before allowing the user access to `Logs\r\nExplorer`.\r\nClicking on the `Logs` tab from the side nav defaults to `Stream`, as\r\nlong as its not depricated, in case the user doesn't have access to\r\n`Logs Explorer`\r\n\r\n## 🎥 Demo\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/a4105ec0-7681-40ee-b2fd-e39b9c178dcf","sha":"dbfd4f0879aa89c49b379cc2c6c5feb74f5c16c7"}},"sourceBranch":"main","suggestedTargetBranches":["8.15","8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193894","number":193894,"mergeCommit":{"message":"[Logs Explorer] Fix Privileges Accessibility (#193894)\n\ncloses https://github.com/elastic/kibana/issues/192062\r\n\r\n## 📝 Summary\r\n\r\nThis PR adds privileges checks for `Logs Explorerer` it checks for\r\n`Discover & Fleet` privileges before allowing the user access to `Logs\r\nExplorer`.\r\nClicking on the `Logs` tab from the side nav defaults to `Stream`, as\r\nlong as its not depricated, in case the user doesn't have access to\r\n`Logs Explorer`\r\n\r\n## 🎥 Demo\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/a4105ec0-7681-40ee-b2fd-e39b9c178dcf","sha":"dbfd4f0879aa89c49b379cc2c6c5feb74f5c16c7"}},{"branch":"8.15","label":"v8.15.0","branchLabelMappingKey":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: mohamedhamed-ahmed <mohamed.ahmed@elastic.co>
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
mohamedhamed-ahmed
added a commit
to mohamedhamed-ahmed/kibana
that referenced
this pull request
Oct 1, 2024
closes elastic#192062 ## 📝 Summary This PR adds privileges checks for `Logs Explorerer` it checks for `Discover & Fleet` privileges before allowing the user access to `Logs Explorer`. Clicking on the `Logs` tab from the side nav defaults to `Stream`, as long as its not depricated, in case the user doesn't have access to `Logs Explorer` ## 🎥 Demo https://github.com/user-attachments/assets/a4105ec0-7681-40ee-b2fd-e39b9c178dcf (cherry picked from commit dbfd4f0) # Conflicts: # x-pack/plugins/observability_solution/infra/public/apps/logs_app.tsx
mohamedhamed-ahmed
added a commit
that referenced
this pull request
Oct 2, 2024
# Backport This will backport the following commits from `main` to `8.15`: - [[Logs Explorer] Fix Privileges Accessibility (#193894)](#193894) <!--- Backport version: 8.9.8 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"mohamedhamed-ahmed","email":"mohamed.ahmed@elastic.co"},"sourceCommit":{"committedDate":"2024-10-01T11:38:16Z","message":"[Logs Explorer] Fix Privileges Accessibility (#193894)\n\ncloses https://github.com/elastic/kibana/issues/192062\r\n\r\n## 📝 Summary\r\n\r\nThis PR adds privileges checks for `Logs Explorerer` it checks for\r\n`Discover & Fleet` privileges before allowing the user access to `Logs\r\nExplorer`.\r\nClicking on the `Logs` tab from the side nav defaults to `Stream`, as\r\nlong as its not depricated, in case the user doesn't have access to\r\n`Logs Explorer`\r\n\r\n## 🎥 Demo\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/a4105ec0-7681-40ee-b2fd-e39b9c178dcf","sha":"dbfd4f0879aa89c49b379cc2c6c5feb74f5c16c7","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","ci:project-deploy-observability","Team:obs-ux-logs","Team:obs-ux-infra_services","apm:review","v8.15.0","v8.16.0","backport:version"],"number":193894,"url":"https://github.com/elastic/kibana/pull/193894","mergeCommit":{"message":"[Logs Explorer] Fix Privileges Accessibility (#193894)\n\ncloses https://github.com/elastic/kibana/issues/192062\r\n\r\n## 📝 Summary\r\n\r\nThis PR adds privileges checks for `Logs Explorerer` it checks for\r\n`Discover & Fleet` privileges before allowing the user access to `Logs\r\nExplorer`.\r\nClicking on the `Logs` tab from the side nav defaults to `Stream`, as\r\nlong as its not depricated, in case the user doesn't have access to\r\n`Logs Explorer`\r\n\r\n## 🎥 Demo\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/a4105ec0-7681-40ee-b2fd-e39b9c178dcf","sha":"dbfd4f0879aa89c49b379cc2c6c5feb74f5c16c7"}},"sourceBranch":"main","suggestedTargetBranches":["8.15"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","labelRegex":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193894","number":193894,"mergeCommit":{"message":"[Logs Explorer] Fix Privileges Accessibility (#193894)\n\ncloses https://github.com/elastic/kibana/issues/192062\r\n\r\n## 📝 Summary\r\n\r\nThis PR adds privileges checks for `Logs Explorerer` it checks for\r\n`Discover & Fleet` privileges before allowing the user access to `Logs\r\nExplorer`.\r\nClicking on the `Logs` tab from the side nav defaults to `Stream`, as\r\nlong as its not depricated, in case the user doesn't have access to\r\n`Logs Explorer`\r\n\r\n## 🎥 Demo\r\n\r\n\r\n\r\nhttps://github.com/user-attachments/assets/a4105ec0-7681-40ee-b2fd-e39b9c178dcf","sha":"dbfd4f0879aa89c49b379cc2c6c5feb74f5c16c7"}},{"branch":"8.15","label":"v8.15.0","labelRegex":"^v(\\d+).(\\d+).\\d+$","isSourceBranch":false,"state":"NOT_CREATED"},{"branch":"8.x","label":"v8.16.0","labelRegex":"^v8.16.0$","isSourceBranch":false,"url":"https://github.com/elastic/kibana/pull/194557","number":194557,"state":"MERGED","mergeCommit":{"sha":"ee920811f6c17f6ea264cc5e3527e63cd2c0fd46","message":"[8.x] [Logs Explorer] Fix Privileges Accessibility (#193894) (#194557)\n\n# Backport\n\nThis will backport the following commits from `main` to `8.x`:\n- [[Logs Explorer] Fix Privileges Accessibility\n(#193894)](https://github.com/elastic/kibana/pull/193894)\n\n<!--- Backport version: 9.4.3 -->\n\n### Questions ?\nPlease refer to the [Backport tool\ndocumentation](https://github.com/sqren/backport)\n\n<!--BACKPORT\n[{\"author\":{\"name\":\"mohamedhamed-ahmed\",\"email\":\"mohamed.ahmed@elastic.co\"},\"sourceCommit\":{\"committedDate\":\"2024-10-01T11:38:16Z\",\"message\":\"[Logs\nExplorer] Fix Privileges Accessibility (#193894)\\n\\ncloses\nhttps://github.com//issues/192062\\r\\n\\r\\n## 📝\nSummary\\r\\n\\r\\nThis PR adds privileges checks for `Logs Explorerer` it\nchecks for\\r\\n`Discover & Fleet` privileges before allowing the user\naccess to `Logs\\r\\nExplorer`.\\r\\nClicking on the `Logs` tab from the\nside nav defaults to `Stream`, as\\r\\nlong as its not depricated, in case\nthe user doesn't have access to\\r\\n`Logs Explorer`\\r\\n\\r\\n## 🎥\nDemo\\r\\n\\r\\n\\r\\n\\r\\nhttps://github.com/user-attachments/assets/a4105ec0-7681-40ee-b2fd-e39b9c178dcf\",\"sha\":\"dbfd4f0879aa89c49b379cc2c6c5feb74f5c16c7\",\"branchLabelMapping\":{\"^v9.0.0$\":\"main\",\"^v8.16.0$\":\"8.x\",\"^v(\\\\d+).(\\\\d+).\\\\d+$\":\"$1.$2\"}},\"sourcePullRequest\":{\"labels\":[\"release_note:skip\",\"v9.0.0\",\"ci:project-deploy-observability\",\"Team:obs-ux-logs\",\"Team:obs-ux-infra_services\",\"v8.15.0\",\"v8.16.0\",\"backport:version\"],\"title\":\"[Logs\nExplorer] Fix Privileges\nAccessibility\",\"number\":193894,\"url\":\"https://github.com/elastic/kibana/pull/193894\",\"mergeCommit\":{\"message\":\"[Logs\nExplorer] Fix Privileges Accessibility (#193894)\\n\\ncloses\nhttps://github.com//issues/192062\\r\\n\\r\\n## 📝\nSummary\\r\\n\\r\\nThis PR adds privileges checks for `Logs Explorerer` it\nchecks for\\r\\n`Discover & Fleet` privileges before allowing the user\naccess to `Logs\\r\\nExplorer`.\\r\\nClicking on the `Logs` tab from the\nside nav defaults to `Stream`, as\\r\\nlong as its not depricated, in case\nthe user doesn't have access to\\r\\n`Logs Explorer`\\r\\n\\r\\n## 🎥\nDemo\\r\\n\\r\\n\\r\\n\\r\\nhttps://github.com/user-attachments/assets/a4105ec0-7681-40ee-b2fd-e39b9c178dcf\",\"sha\":\"dbfd4f0879aa89c49b379cc2c6c5feb74f5c16c7\"}},\"sourceBranch\":\"main\",\"suggestedTargetBranches\":[\"8.15\",\"8.x\"],\"targetPullRequestStates\":[{\"branch\":\"main\",\"label\":\"v9.0.0\",\"branchLabelMappingKey\":\"^v9.0.0$\",\"isSourceBranch\":true,\"state\":\"MERGED\",\"url\":\"https://github.com/elastic/kibana/pull/193894\",\"number\":193894,\"mergeCommit\":{\"message\":\"[Logs\nExplorer] Fix Privileges Accessibility (#193894)\\n\\ncloses\nhttps://github.com//issues/192062\\r\\n\\r\\n## 📝\nSummary\\r\\n\\r\\nThis PR adds privileges checks for `Logs Explorerer` it\nchecks for\\r\\n`Discover & Fleet` privileges before allowing the user\naccess to `Logs\\r\\nExplorer`.\\r\\nClicking on the `Logs` tab from the\nside nav defaults to `Stream`, as\\r\\nlong as its not depricated, in case\nthe user doesn't have access to\\r\\n`Logs Explorer`\\r\\n\\r\\n## 🎥\nDemo\\r\\n\\r\\n\\r\\n\\r\\nhttps://github.com/user-attachments/assets/a4105ec0-7681-40ee-b2fd-e39b9c178dcf\",\"sha\":\"dbfd4f0879aa89c49b379cc2c6c5feb74f5c16c7\"}},{\"branch\":\"8.15\",\"label\":\"v8.15.0\",\"branchLabelMappingKey\":\"^v(\\\\d+).(\\\\d+).\\\\d+$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"},{\"branch\":\"8.x\",\"label\":\"v8.16.0\",\"branchLabelMappingKey\":\"^v8.16.0$\",\"isSourceBranch\":false,\"state\":\"NOT_CREATED\"}]}]\nBACKPORT-->\n\nCo-authored-by: mohamedhamed-ahmed <mohamed.ahmed@elastic.co>"}}]}] BACKPORT-->
mohamedhamed-ahmed
added a commit
to mohamedhamed-ahmed/kibana
that referenced
this pull request
Oct 30, 2024
closes elastic#192062 This PR adds privileges checks for `Logs Explorerer` it checks for `Discover & Fleet` privileges before allowing the user access to `Logs Explorer`. Clicking on the `Logs` tab from the side nav defaults to `Stream`, as long as its not depricated, in case the user doesn't have access to `Logs Explorer` https://github.com/user-attachments/assets/a4105ec0-7681-40ee-b2fd-e39b9c178dcf (cherry picked from commit dbfd4f0)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #192062
📝 Summary
This PR adds privileges checks for
Logs Explorererit checks forDiscover & Fleetprivileges before allowing the user access toLogs Explorer.Clicking on the
Logstab from the side nav defaults toStream, as long as its not depricated, in case the user doesn't have access toLogs Explorer🎥 Demo
Demo.mov