Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution][Detection Engine] removes field_caps call for all fields in index during rule execution #193869

Draft
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

vitaliidm
Copy link
Contributor

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@vitaliidm vitaliidm self-assigned this Sep 24, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 24, 2024

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!

@vitaliidm vitaliidm added release_note:skip Skip the PR/issue when compiling release notes Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc. Team:Detection Engine Security Solution Detection Engine Area 8.16 candidate backport:prev-minor Backport to the previous minor version (i.e. one version back from main) labels Sep 24, 2024
@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 24, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #12 / Configuration button renders the tooltip correctly when hovering the button
  • [job] [logs] Jest Tests #12 / FilterPopover renders button label correctly
  • [job] [logs] Jest Tests #3 / threshold_executor thresholdExecutor should clean up any signal history that has fallen outside the window when state is initialized
  • [job] [logs] Jest Tests #3 / threshold_executor thresholdExecutor should clean up any signal history that has fallen outside the window when state is initialized
  • [job] [logs] Jest Tests #3 / threshold_executor thresholdExecutor should log a warning if unprocessedExceptions is not empty
  • [job] [logs] Jest Tests #3 / threshold_executor thresholdExecutor should log a warning if unprocessedExceptions is not empty

Metrics [docs]

✅ unchanged

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @vitaliidm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.16 candidate backport:prev-minor Backport to the previous minor version (i.e. one version back from main) release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area Team: SecuritySolution Security Solutions Team working on SIEM, Endpoint, Timeline, Resolver, etc.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants