Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apache 2.0 license headers #19383

Merged
merged 8 commits into from
May 29, 2018

Conversation

spalger
Copy link
Contributor

@spalger spalger commented May 24, 2018

In order to make the license that applies to each file as clear as possible, and to be consistent with elasticsearch, we are adding Apache 2.0 license headers to the top of each file.

Existence of this header is enforced by eslint and tslint and missing headers were automatically added in the last commit by running:

node scripts/eslint --fix && node scripts/tslint --fix

@elasticmachine
Copy link
Contributor

💔 Build Failed

@jimgoodwin
Copy link

Does this cover CSS files (or the files we use to generate CSS), HTML templates etc ?

@spalger
Copy link
Contributor Author

spalger commented May 24, 2018

@jimgoodwin no, we decided a while back to only add license headers to JS files (I'm including TS files because they serve the same purpose)

@jimgoodwin
Copy link

Ok, cool...

@epixa
Copy link
Contributor

epixa commented May 24, 2018

How does this know to ignore vendored files like webpackShims?

@spalger
Copy link
Contributor Author

spalger commented May 24, 2018

It's a mixture of /* eslint-disable @kbn/license-header/require-license-header */ (example) directives and .eslintignore (example). Since the .js side of this is powered by eslint anything that is explicitly ignored won't get the license header or be checked for it.

@epixa
Copy link
Contributor

epixa commented May 24, 2018

The changes look good at a high level, but let's get the word out before we push this change so people can prepare their PRs and whatnot, and let's get confirmation on the license text.

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@elasticmachine
Copy link
Contributor

💚 Build Succeeded

@spalger spalger merged commit f0cc432 into elastic:master May 29, 2018
@spalger
Copy link
Contributor Author

spalger commented May 29, 2018

6.4/6.x: 4f29b32

@spalger spalger deleted the implement/apache-2-license-headers branch May 29, 2018 03:25
@elasticmachine
Copy link
Contributor

💚 Build Succeeded

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants