Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [data views] Remove regex for creating dot notation (#193795) #193809

Merged
merged 1 commit into from
Sep 24, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

## Summary

Use basic string and array functions instead of regex to create short
dot field names.

(cherry picked from commit ab9459c)
@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #12 / blocklist form should correctly edit single value
  • [job] [logs] Jest Tests #12 / Response actions history page Read from URL params should read and expand actions using withOutputs
  • [job] [logs] Jest Tests #12 / Response actions history page Read from URL params should read and set command filter values from URL params

Metrics [docs]

Page load bundle

Size of the bundles that are downloaded on every page load. Target size is below 100kb

id before after diff
dataViews 62.2KB 62.3KB +67.0B

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @mattkime

@kibanamachine kibanamachine merged commit 87ac87a into elastic:8.x Sep 24, 2024
26 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants