Upgrade EUI to v95.12.0 #193805
Merged
Upgrade EUI to v95.12.0 #193805
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cee-chen
added
release_note:skip
cee-chen
force-pushed
the
eui/v95.12.0
branch
2 times, most recently
from
55e0a37
to
edbea88
Compare
2 tasks
cee-chen
force-pushed
the
eui/v95.12.0
branch
3 times, most recently
from
520f082
to
8181706
Compare
- `jest.fn()` is legitimately not available (or possibly getting overwritten) and causing undefined failures down the road - just replace `jest.fn()`s with static fns / noops since no one is mocking or listening to them in any case
cee-chen
force-pushed
the
eui/v95.12.0
branch
from
8181706
to
afe7d4a
Compare
+ harden header control columns to exclude SR text as well
cee-chen
force-pushed
the
eui/v95.12.0
branch
from
afe7d4a
to
362c4c4
Compare
|
Pinging @elastic/eui-team (EUI) |
cee-chen
force-pushed
the
eui/v95.12.0
branch
from
e0a80cf
to
fb7f31d
Compare
jbudz
reviewed
Sep 26, 2024
jughosta
reviewed
Sep 26, 2024
| @@ -199,7 +199,7 @@ export default function ({ getService, getPageObjects }: FtrProviderContext) { | |||
| const cell = await dataGrid.getCellElementExcludingControlColumns(0, 1); | |||
| expect(await cell.getVisibleText()).to.be(' - '); | |||
| expect(await dataGrid.getHeaders()).to.eql([ | |||
| "Select columnPress the Enter key to interact with this cell's contents.", // contains screen reader help text | |||
| 'Select column', | |||
There was a problem hiding this comment.
Hi @cee-chen,
Sorry, I don't have a chance to review the PR fully this week. From a quick look, it seems like the row controls can get misaligned depending on the display settings:
There was a problem hiding this comment.
Will take a look at this, thanks for flagging it Julia!
There was a problem hiding this comment.
Fixed now with the latest commits:
The EUI changes let me clean up a bunch of extra wrappers while also making the checkboxes/buttons shift less when switching between single and custom! 🥳
- flex groups and extra padding are no longer necessary with the new EuiDataGrid row height fixes
- remove `<DataTableRowControl />` altogether - the size doesn't appear to do anything and the extra `<span>` wrapper interferes with our ability to vertically align w/ line-height - tweak negative margin-tops by minute amounts, as that's all that's needed at this point
cee-chen
force-pushed
the
eui/v95.12.0
branch
from
f83ecb5
to
1eb4448
Compare
paul-tavares
approved these changes
Sep 27, 2024
MichaelMarcialis
approved these changes
Sep 30, 2024
jaredburgettelastic
approved these changes
Sep 30, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]Module Count
Public APIs missing comments
Async chunks
Public APIs missing exports
Page load bundle
Unknown metric groupsAPI count
ESLint disabled line counts
Total ESLint disabled count
History
To update your PR or re-run it, just comment with: |
|
Starting backport for target branches: 8.x |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 30, 2024
`v95.11.0`⏩`v95.12.0-backport.0` > [!note] > A few fun highlights from this release: > - Content within `EuiDataGrid`, `EuiBasicTable`, and `EuiInMemoryTable`, when manually selected/highlighted by users, should now more cleanly copy and paste into various spreadsheet apps > - `EuiProvider` will now detect the user's system-level dark or light mode and default to that if no `colorMode` prop is passed manually _[Questions? Please see our Kibana upgrade FAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_ --- ## [`v95.12.0`](https://github.com/elastic/eui/releases/v95.12.0) - Enhanced `EuiDataGrid` and `EuiBasic/InMemoryTable` to clean content newlines/tabs when users copy and paste from their tabular data ([elastic#8019](elastic/eui#8019)) - Updated `EuiResizableButton` with a new `accountForScrollbars` prop ([elastic#8021](elastic/eui#8021)) - Updated `EuiProvider` to inherit from the user's OS/system light/dark mode setting if a `colorMode` prop has not been passed ([elastic#8026](elastic/eui#8026)) **Bug fixes** - Fixed `EuiDatePicker`'s `onClear` button to not appear when the input is `disabled` ([elastic#8020](elastic/eui#8020)) - Fixed several `EuiDataGrid` row height bugs: ([elastic#8025](elastic/eui#8025)) - Fixed row heights not recalculating when `rowHeightOptions.lineHeight`, `gridStyles.fontSize`, or `gridStyles.cellPadding` changed - Fixed incorrect height calculations for `rowHeightOptions.rowHeights` with `lineCount`s - Fixed control column content to align better with multi-line row heights, as well as custom line-heights ## [`v95.12.0-backport.0`](https://github.com/elastic/eui/releases/v95.12.0-backport.0) **This is a backport release only intended for use by Kibana.** **Bug fixes** - Fixed `EuiProvider`'s system color mode detection causing errors during server-side rendering ([elastic#8040](elastic/eui#8040)) - Fixed an `EuiDataGrid` rendering bug that was causing bouncing scrollbar issues ([elastic#8041](elastic/eui#8041)) (cherry picked from commit 8a89c85)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Oct 1, 2024
# Backport This will backport the following commits from `main` to `8.x`: - [Upgrade EUI to v95.12.0 (#193805)](#193805) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Cee Chen","email":"549407+cee-chen@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-09-30T23:25:47Z","message":"Upgrade EUI to v95.12.0 (#193805)\n\n`v95.11.0`⏩`v95.12.0-backport.0`\r\n\r\n> [!note]\r\n> A few fun highlights from this release:\r\n> - Content within `EuiDataGrid`, `EuiBasicTable`, and\r\n`EuiInMemoryTable`, when manually selected/highlighted by users, should\r\nnow more cleanly copy and paste into various spreadsheet apps\r\n> - `EuiProvider` will now detect the user's system-level dark or light\r\nmode and default to that if no `colorMode` prop is passed manually\r\n\r\n_[Questions? Please see our Kibana upgrade\r\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_\r\n\r\n---\r\n\r\n## [`v95.12.0`](https://github.com/elastic/eui/releases/v95.12.0)\r\n\r\n- Enhanced `EuiDataGrid` and `EuiBasic/InMemoryTable` to clean content\r\nnewlines/tabs when users copy and paste from their tabular data\r\n([#8019](https://github.com/elastic/eui/pull/8019))\r\n- Updated `EuiResizableButton` with a new `accountForScrollbars` prop\r\n([#8021](https://github.com/elastic/eui/pull/8021))\r\n- Updated `EuiProvider` to inherit from the user's OS/system light/dark\r\nmode setting if a `colorMode` prop has not been passed\r\n([#8026](https://github.com/elastic/eui/pull/8026))\r\n\r\n**Bug fixes**\r\n\r\n- Fixed `EuiDatePicker`'s `onClear` button to not appear when the input\r\nis `disabled` ([#8020](https://github.com/elastic/eui/pull/8020))\r\n- Fixed several `EuiDataGrid` row height bugs:\r\n([#8025](https://github.com/elastic/eui/pull/8025))\r\n- Fixed row heights not recalculating when\r\n`rowHeightOptions.lineHeight`, `gridStyles.fontSize`, or\r\n`gridStyles.cellPadding` changed\r\n- Fixed incorrect height calculations for `rowHeightOptions.rowHeights`\r\nwith `lineCount`s\r\n- Fixed control column content to align better with multi-line row\r\nheights, as well as custom line-heights\r\n##\r\n[`v95.12.0-backport.0`](https://github.com/elastic/eui/releases/v95.12.0-backport.0)\r\n\r\n**This is a backport release only intended for use by Kibana.**\r\n\r\n**Bug fixes**\r\n\r\n- Fixed `EuiProvider`'s system color mode detection causing errors\r\nduring server-side rendering\r\n([#8040](https://github.com/elastic/eui/pull/8040))\r\n- Fixed an `EuiDataGrid` rendering bug that was causing bouncing\r\nscrollbar issues ([#8041](https://github.com/elastic/eui/pull/8041))","sha":"8a89c8576df104c16ae3abf39b9db766e56d4e3b","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","EUI","v9.0.0","v8.16.0","backport:version"],"title":"Upgrade EUI to v95.12.0","number":193805,"url":"https://github.com/elastic/kibana/pull/193805","mergeCommit":{"message":"Upgrade EUI to v95.12.0 (#193805)\n\n`v95.11.0`⏩`v95.12.0-backport.0`\r\n\r\n> [!note]\r\n> A few fun highlights from this release:\r\n> - Content within `EuiDataGrid`, `EuiBasicTable`, and\r\n`EuiInMemoryTable`, when manually selected/highlighted by users, should\r\nnow more cleanly copy and paste into various spreadsheet apps\r\n> - `EuiProvider` will now detect the user's system-level dark or light\r\nmode and default to that if no `colorMode` prop is passed manually\r\n\r\n_[Questions? Please see our Kibana upgrade\r\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_\r\n\r\n---\r\n\r\n## [`v95.12.0`](https://github.com/elastic/eui/releases/v95.12.0)\r\n\r\n- Enhanced `EuiDataGrid` and `EuiBasic/InMemoryTable` to clean content\r\nnewlines/tabs when users copy and paste from their tabular data\r\n([#8019](https://github.com/elastic/eui/pull/8019))\r\n- Updated `EuiResizableButton` with a new `accountForScrollbars` prop\r\n([#8021](https://github.com/elastic/eui/pull/8021))\r\n- Updated `EuiProvider` to inherit from the user's OS/system light/dark\r\nmode setting if a `colorMode` prop has not been passed\r\n([#8026](https://github.com/elastic/eui/pull/8026))\r\n\r\n**Bug fixes**\r\n\r\n- Fixed `EuiDatePicker`'s `onClear` button to not appear when the input\r\nis `disabled` ([#8020](https://github.com/elastic/eui/pull/8020))\r\n- Fixed several `EuiDataGrid` row height bugs:\r\n([#8025](https://github.com/elastic/eui/pull/8025))\r\n- Fixed row heights not recalculating when\r\n`rowHeightOptions.lineHeight`, `gridStyles.fontSize`, or\r\n`gridStyles.cellPadding` changed\r\n- Fixed incorrect height calculations for `rowHeightOptions.rowHeights`\r\nwith `lineCount`s\r\n- Fixed control column content to align better with multi-line row\r\nheights, as well as custom line-heights\r\n##\r\n[`v95.12.0-backport.0`](https://github.com/elastic/eui/releases/v95.12.0-backport.0)\r\n\r\n**This is a backport release only intended for use by Kibana.**\r\n\r\n**Bug fixes**\r\n\r\n- Fixed `EuiProvider`'s system color mode detection causing errors\r\nduring server-side rendering\r\n([#8040](https://github.com/elastic/eui/pull/8040))\r\n- Fixed an `EuiDataGrid` rendering bug that was causing bouncing\r\nscrollbar issues ([#8041](https://github.com/elastic/eui/pull/8041))","sha":"8a89c8576df104c16ae3abf39b9db766e56d4e3b"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193805","number":193805,"mergeCommit":{"message":"Upgrade EUI to v95.12.0 (#193805)\n\n`v95.11.0`⏩`v95.12.0-backport.0`\r\n\r\n> [!note]\r\n> A few fun highlights from this release:\r\n> - Content within `EuiDataGrid`, `EuiBasicTable`, and\r\n`EuiInMemoryTable`, when manually selected/highlighted by users, should\r\nnow more cleanly copy and paste into various spreadsheet apps\r\n> - `EuiProvider` will now detect the user's system-level dark or light\r\nmode and default to that if no `colorMode` prop is passed manually\r\n\r\n_[Questions? Please see our Kibana upgrade\r\nFAQ.](https://github.com/elastic/eui/blob/main/wiki/eui-team-processes/upgrading-kibana.md#faq-for-kibana-teams)_\r\n\r\n---\r\n\r\n## [`v95.12.0`](https://github.com/elastic/eui/releases/v95.12.0)\r\n\r\n- Enhanced `EuiDataGrid` and `EuiBasic/InMemoryTable` to clean content\r\nnewlines/tabs when users copy and paste from their tabular data\r\n([#8019](https://github.com/elastic/eui/pull/8019))\r\n- Updated `EuiResizableButton` with a new `accountForScrollbars` prop\r\n([#8021](https://github.com/elastic/eui/pull/8021))\r\n- Updated `EuiProvider` to inherit from the user's OS/system light/dark\r\nmode setting if a `colorMode` prop has not been passed\r\n([#8026](https://github.com/elastic/eui/pull/8026))\r\n\r\n**Bug fixes**\r\n\r\n- Fixed `EuiDatePicker`'s `onClear` button to not appear when the input\r\nis `disabled` ([#8020](https://github.com/elastic/eui/pull/8020))\r\n- Fixed several `EuiDataGrid` row height bugs:\r\n([#8025](https://github.com/elastic/eui/pull/8025))\r\n- Fixed row heights not recalculating when\r\n`rowHeightOptions.lineHeight`, `gridStyles.fontSize`, or\r\n`gridStyles.cellPadding` changed\r\n- Fixed incorrect height calculations for `rowHeightOptions.rowHeights`\r\nwith `lineCount`s\r\n- Fixed control column content to align better with multi-line row\r\nheights, as well as custom line-heights\r\n##\r\n[`v95.12.0-backport.0`](https://github.com/elastic/eui/releases/v95.12.0-backport.0)\r\n\r\n**This is a backport release only intended for use by Kibana.**\r\n\r\n**Bug fixes**\r\n\r\n- Fixed `EuiProvider`'s system color mode detection causing errors\r\nduring server-side rendering\r\n([#8040](https://github.com/elastic/eui/pull/8040))\r\n- Fixed an `EuiDataGrid` rendering bug that was causing bouncing\r\nscrollbar issues ([#8041](https://github.com/elastic/eui/pull/8041))","sha":"8a89c8576df104c16ae3abf39b9db766e56d4e3b"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Cee Chen <549407+cee-chen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
v95.11.0⏩v95.12.0-backport.0Note
A few fun highlights from this release:
EuiDataGrid,EuiBasicTable, andEuiInMemoryTable, when manually selected/highlighted by users, should now more cleanly copy and paste into various spreadsheet appsEuiProviderwill now detect the user's system-level dark or light mode and default to that if nocolorModeprop is passed manuallyQuestions? Please see our Kibana upgrade FAQ.
v95.12.0EuiDataGridandEuiBasic/InMemoryTableto clean content newlines/tabs when users copy and paste from their tabular data (#8019)EuiResizableButtonwith a newaccountForScrollbarsprop (#8021)EuiProviderto inherit from the user's OS/system light/dark mode setting if acolorModeprop has not been passed (#8026)Bug fixes
EuiDatePicker'sonClearbutton to not appear when the input isdisabled(#8020)EuiDataGridrow height bugs: (#8025)rowHeightOptions.lineHeight,gridStyles.fontSize, orgridStyles.cellPaddingchangedrowHeightOptions.rowHeightswithlineCountsv95.12.0-backport.0This is a backport release only intended for use by Kibana.
Bug fixes
EuiProvider's system color mode detection causing errors during server-side rendering (#8040)EuiDataGridrendering bug that was causing bouncing scrollbar issues (#8041)