[8.x] [ES|QL] new pattern for SORT autocomplete (#193595)
#193801
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
## Summary Part of elastic#189662. This PR - updates the autocomplete behavior for `SORT` to be in line with other field-list-based experiences like `KEEP` - introduces a shared function, `handleFragment`, which is used to abstract some of the logic required to support this behavior - bulks up the `SORT` tests - restores the function suggestions which I noticed got lost in elastic#189959 **Before** https://github.com/user-attachments/assets/cad1d073-c010-426f-9628-c0fc6b65eb3c **After** https://github.com/user-attachments/assets/e148ae58-4430-482c-9f8e-c55779c4d822 ### Checklist - [x] [Unit or functional tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html) were updated or added to match the most common scenarios --------- Co-authored-by: Stratoula Kalafateli <efstratia.kalafateli@elastic.co> (cherry picked from commit f450e22)
1 task
💚 Build Succeeded
Metrics [docs]Page load bundle
To update your PR or re-run it, just comment with: |
stratoula
approved these changes
Sep 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport
This will backport the following commits from
mainto8.x:SORTautocomplete (#193595)Questions ?
Please refer to the Backport tool documentation