Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x] [Dev Server] Remove dead code (#193736) #193759

Merged
merged 1 commit into from
Sep 23, 2024
Merged

[8.x] [Dev Server] Remove dead code (#193736) #193759

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 0 additions & 10 deletions packages/kbn-cli-dev-mode/src/dev_server.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -196,16 +196,6 @@ export class DevServer {
this.phase$.next('listening');
this.ready$.next(true);
}

// TODO: remove this once Pier is done migrating log rotation to KP
if (msg === 'RELOAD_LOGGING_CONFIG_FROM_SERVER_WORKER') {
// When receive that event from server worker
// forward a reloadLoggingConfig message to parent
// and child proc. This is only used by LogRotator service
// when the cluster mode is enabled
process.emit('message' as any, { reloadLoggingConfig: true } as any);
proc.send({ reloadLoggingConfig: true });
}
}),
takeUntil(exit$)
);
Expand Down