[RCA] Fix equation for rule condition chart #193689
Open
+6
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benakansara
added
release_note:skip
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
botelastic
bot
added
the
ci:project-deploy-observability
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
| @@ -26,7 +26,7 @@ const genLensEqForCustomThresholdRule = (criterion: MetricExpression) => { | |||
| (metric: CustomThresholdExpressionMetric) => | |||
| (metricNameResolver[metric.name] = `${ | |||
| AggMappingForLens[metric.aggType] ? AggMappingForLens[metric.aggType] : metric.aggType | |||
| }(${metric.field ? metric.field : metric.filter ? metric.filter : ''})`) | |||
| }(${metric.field ? metric.field : metric.filter ? `kql='${metric.filter}'` : ''})`) | |||
There was a problem hiding this comment.
Could you separate out this double ternary into two ternaries? Reading the double ternary is hard.
Suggested change
| }(${metric.field ? metric.field : metric.filter ? `kql='${metric.filter}'` : ''})`) | |
| const metricFilter = metric.filter ? `kql='${metric.filter}'` : ''; | |
| ... | |
| }(${metric.field ? metric.field : metricFilter) |
There was a problem hiding this comment.
sure, updated in f7578a8
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: cc @benakansara |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #193688