[Fleet] Use UUID to Ensure Unique Service Token for Fleet Server #193596
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
the
Team:Fleet
|
💚 CLA has been signed |
|
Pinging @elastic/fleet (Team:Fleet) |
nchaulet
reviewed
Sep 20, 2024
| @@ -133,7 +134,7 @@ export const generateServiceTokenHandler: RequestHandler< | |||
| token?: GenerateServiceTokenResponse; | |||
| }>({ | |||
| method: 'POST', | |||
| path: `_security/service/elastic/${serviceAccount}/credential/token/token-${Date.now()}`, | |||
| path: `_security/service/elastic/${serviceAccount}/credential/token/token-${uuidv4()}`, | |||
There was a problem hiding this comment.
thanks for the contribution. @swapanmandi it seems elasticsearch is already generating a uuid if the name is not passed, so I think we can use that behaviour and directly call /credential/token without a name
nchaulet
requested changes
Sep 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix #193537
Description:
This PR fixes the issue of potential conflicts when generating service tokens for the Fleet server by using the uuid library to ensure unique token names. Previously, there was a risk of token name collisions due to timestamp-based token names, which could cause conflicts during token creation.
Key changes:
Implemented uuidv4() to generate unique service token names.
Updated service token creation logic to use the unique identifier in the token path.uses a timestamp for the token name, which is not guaranteed to be unique.