Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet] Improve reusable integration policies flow in package policies UI #193532

Draft
wants to merge 6 commits into
base: main
Choose a base branch
from

Conversation

criamico
Copy link
Contributor

@criamico criamico commented Sep 20, 2024

Closes #186357

Summary

Summarize your PR. If it involves visual changes include a screenshot or gif.

Checklist

Delete any items that are not applicable to this PR.

Risk Matrix

Delete this section if it is not applicable to this PR.

Before closing this PR, invite QA, stakeholders, and other developers to identify risks that should be tested prior to the change/feature release.

When forming the risk matrix, consider some of the following examples and how they may potentially impact the change:

Risk Probability Severity Mitigation/Notes
Multiple Spaces—unexpected behavior in non-default Kibana Space. Low High Integration tests will verify that all features are still supported in non-default Kibana Space and when user switches between spaces.
Multiple nodes—Elasticsearch polling might have race conditions when multiple Kibana nodes are polling for the same tasks. High Low Tasks are idempotent, so executing them multiple times will not result in logical error, but will degrade performance. To test for this case we add plenty of unit tests around this logic and document manual testing procedure.
Code should gracefully handle cases when feature X or plugin Y are disabled. Medium High Unit tests will verify that any feature flag or plugin combination still results in our service operational.
See more potential risk examples

For maintainers

@criamico criamico self-assigned this Sep 20, 2024
@elasticmachine
Copy link
Contributor

elasticmachine commented Sep 20, 2024

🤖 Jobs for this PR can be triggered through checkboxes. 🚧

ℹ️ To trigger the CI, please tick the checkbox below 👇

  • Click to trigger kibana-pull-request for this PR!

@criamico criamico changed the title [Fleet] Improve reusable integration policies flow in package policie… [Fleet] Improve reusable integration policies flow in package policies UI Sep 20, 2024
@obltmachine
Copy link

🤖 GitHub comments

Expand to view the GitHub comments

Just comment with:

  • /oblt-deploy : Deploy a Kibana instance using the Observability test environments.
  • run docs-build : Re-trigger the docs validation. (use unformatted text in the comment!)

@criamico criamico added the Team:Fleet Team label for Observability Data Collection Fleet team label Sep 23, 2024
@criamico
Copy link
Contributor Author

@elasticmachine merge upstream

@criamico
Copy link
Contributor Author

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

kibana-ci commented Sep 24, 2024

💔 Build Failed

Failed CI Steps

Test Failures

  • [job] [logs] Jest Tests #14 / PackagePolicyAgentsCell it should be disabled if canAddAgents is false
  • [job] [logs] Jest Tests #14 / PackagePolicyAgentsCell it should be disabled if canAddAgents is false
  • [job] [logs] Jest Tests #14 / PackagePolicyAgentsCell it should display add agent if count is 0
  • [job] [logs] Jest Tests #14 / PackagePolicyAgentsCell it should display add agent if count is 0
  • [job] [logs] Jest Tests #14 / PackagePolicyAgentsCell it should display help popover if count is 0 and hasHelpPopover=true
  • [job] [logs] Jest Tests #14 / PackagePolicyAgentsCell it should display help popover if count is 0 and hasHelpPopover=true
  • [job] [logs] Jest Tests #14 / PackagePolicyAgentsCell it should display only count if count > 0
  • [job] [logs] Jest Tests #14 / PackagePolicyAgentsCell it should display only count if count > 0
  • [job] [logs] Jest Tests #14 / PackagePolicyAgentsCell it should not display help popover if count is > 0 and hasHelpPopover=true
  • [job] [logs] Jest Tests #14 / PackagePolicyAgentsCell it should not display help popover if count is > 0 and hasHelpPopover=true

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
fleet 1.7MB 1.7MB +2.3KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @criamico

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Fleet] Update elements in integration policies table to work with multiple agent policies
5 participants