Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x] [Security Solution] Adds enable on install UI workflow to prebuilt rules page (#191529) #193368

Merged
merged 3 commits into from
Sep 19, 2024

Conversation

kibanamachine
Copy link
Contributor

Backport

This will backport the following commits from main to 8.x:

Questions ?

Please refer to the Backport tool documentation

…les page (elastic#191529)

## Summary

Adds overflow button UI to all prebuilt rules install buttons in order
to enable the rule when it is successfully installed. Previously, a user
would have to navigate back to the rules page and find the rule(s) they
just installed to enable, this combines those two workflows into a
single button action - speeding up the out of the box rule
implementation.

### Screenshots
**Prebuilt rules table columns**
<img width="530" alt="Screenshot 2024-09-04 at 10 38 05 AM"
src="https://github.com/user-attachments/assets/4a009afa-a8f0-4eaa-a76b-8f4e509f35a3">

**Prebuilt rules table bulk install**
<img width="1478" alt="Screenshot 2024-09-04 at 10 38 16 AM"
src="https://github.com/user-attachments/assets/eb6deb9b-9b4e-4be3-a4ac-0da06d6f1e8e">

**Prebuilt rule details flyout**
<img width="1489" alt="Screenshot 2024-09-04 at 10 38 44 AM"
src="https://github.com/user-attachments/assets/a4bce22d-7e90-42e4-8522-cf411a297659">

### Checklist

Delete any items that are not applicable to this PR.

- [x] Any text added follows [EUI's writing
guidelines](https://elastic.github.io/eui/#/guidelines/writing), uses
sentence case text and includes [i18n
support](https://github.com/elastic/kibana/blob/main/packages/kbn-i18n/README.md)
- [ ]
[Documentation](https://www.elastic.co/guide/en/kibana/master/development-documentation.html)
was added for features that require explanation or tutorials
- [ ] [Unit or functional
tests](https://www.elastic.co/guide/en/kibana/master/development-tests.html)
were updated or added to match the most common scenarios
- [ ] [Flaky Test
Runner](https://ci-stats.kibana.dev/trigger_flaky_test_runner/1) was
used on any tests changed

### For maintainers

- [ ] This was checked for breaking API changes and was [labeled
appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)

(cherry picked from commit 3bea483)
@dplumlee
Copy link
Contributor

@elasticmachine merge upstream

@banderror
Copy link
Contributor

@elasticmachine merge upstream

@kibana-ci
Copy link
Collaborator

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

  • [job] [logs] FTR Configs #43 / dashboard app - group 4 dashboard empty state adds a new data view when no data views

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 5799 5800 +1

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.4MB 20.4MB +1.8KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @dplumlee

@kibanamachine kibanamachine merged commit ef37576 into elastic:8.x Sep 19, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants