Add debug logging to session cleanup api integration test #193259
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SiddharthMantri
added
Team:Security
|
Pinging @elastic/kibana-security (Team:Security) |
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
To update your PR or re-run it, just comment with: |
elena-shostak
approved these changes
Sep 18, 2024
azasypkin
reviewed
Sep 18, 2024
| @@ -18,6 +18,7 @@ import { FtrProviderContext } from '../../ftr_provider_context'; | |||
|
|
|||
| export default function ({ getService }: FtrProviderContext) { | |||
There was a problem hiding this comment.
question: would you mind also doing this for session_invalidate and session_concurrent_limit suites? Just in case. And we'll also need to backport this to all active branches (except for 7.17) to increase the chance of catching it.
There was a problem hiding this comment.
Done here: #193279
SiddharthMantri
added
backport:all-open
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 19, 2024
…3259) ## Summary Add settings to the ES Test cluster to enable debug logs so that if this test fails in the future, we will have more logs to investigate the issue. __Related:__ elastic#152260 (cherry picked from commit aaa53f5)
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 19, 2024
…3259) ## Summary Add settings to the ES Test cluster to enable debug logs so that if this test fails in the future, we will have more logs to investigate the issue. __Related:__ elastic#152260 (cherry picked from commit aaa53f5)
💔 Some backports could not be created
Note: Successful backport PRs will be merged automatically after passing CI. Manual backportTo create the backport manually run: Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Sep 19, 2024
…3259) (#193435) # Backport This will backport the following commits from `main` to `8.15`: - [Add debug logging to session cleanup api integration test (#193259)](#193259) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sid","email":"siddharthmantri1@gmail.com"},"sourceCommit":{"committedDate":"2024-09-18T11:57:03Z","message":"Add debug logging to session cleanup api integration test (#193259)\n\n## Summary\r\n\r\nAdd settings to the ES Test cluster to enable debug logs so that if this\r\ntest fails in the future, we will have more logs to investigate the\r\nissue.\r\n\r\n\r\n__Related:__ https://github.com/elastic/kibana/issues/152260","sha":"aaa53f5a31ffe094d2a71f614ce546983a821d57","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","v9.0.0","backport:all-open"],"title":"Add debug logging to session cleanup api integration test","number":193259,"url":"https://github.com/elastic/kibana/pull/193259","mergeCommit":{"message":"Add debug logging to session cleanup api integration test (#193259)\n\n## Summary\r\n\r\nAdd settings to the ES Test cluster to enable debug logs so that if this\r\ntest fails in the future, we will have more logs to investigate the\r\nissue.\r\n\r\n\r\n__Related:__ https://github.com/elastic/kibana/issues/152260","sha":"aaa53f5a31ffe094d2a71f614ce546983a821d57"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193259","number":193259,"mergeCommit":{"message":"Add debug logging to session cleanup api integration test (#193259)\n\n## Summary\r\n\r\nAdd settings to the ES Test cluster to enable debug logs so that if this\r\ntest fails in the future, we will have more logs to investigate the\r\nissue.\r\n\r\n\r\n__Related:__ https://github.com/elastic/kibana/issues/152260","sha":"aaa53f5a31ffe094d2a71f614ce546983a821d57"}}]}] BACKPORT--> Co-authored-by: Sid <siddharthmantri1@gmail.com>
kibanamachine
added a commit
that referenced
this pull request
Sep 19, 2024
) (#193436) # Backport This will backport the following commits from `main` to `8.x`: - [Add debug logging to session cleanup api integration test (#193259)](#193259) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Sid","email":"siddharthmantri1@gmail.com"},"sourceCommit":{"committedDate":"2024-09-18T11:57:03Z","message":"Add debug logging to session cleanup api integration test (#193259)\n\n## Summary\r\n\r\nAdd settings to the ES Test cluster to enable debug logs so that if this\r\ntest fails in the future, we will have more logs to investigate the\r\nissue.\r\n\r\n\r\n__Related:__ https://github.com/elastic/kibana/issues/152260","sha":"aaa53f5a31ffe094d2a71f614ce546983a821d57","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["Team:Security","release_note:skip","v9.0.0","backport:all-open"],"title":"Add debug logging to session cleanup api integration test","number":193259,"url":"https://github.com/elastic/kibana/pull/193259","mergeCommit":{"message":"Add debug logging to session cleanup api integration test (#193259)\n\n## Summary\r\n\r\nAdd settings to the ES Test cluster to enable debug logs so that if this\r\ntest fails in the future, we will have more logs to investigate the\r\nissue.\r\n\r\n\r\n__Related:__ https://github.com/elastic/kibana/issues/152260","sha":"aaa53f5a31ffe094d2a71f614ce546983a821d57"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/193259","number":193259,"mergeCommit":{"message":"Add debug logging to session cleanup api integration test (#193259)\n\n## Summary\r\n\r\nAdd settings to the ES Test cluster to enable debug logs so that if this\r\ntest fails in the future, we will have more logs to investigate the\r\nissue.\r\n\r\n\r\n__Related:__ https://github.com/elastic/kibana/issues/152260","sha":"aaa53f5a31ffe094d2a71f614ce546983a821d57"}}]}] BACKPORT--> Co-authored-by: Sid <siddharthmantri1@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add settings to the ES Test cluster to enable debug logs so that if this test fails in the future, we will have more logs to investigate the issue.
Related: #152260