[Cloud Security] Cypress Test for Misconfiguration Preview and Table for Contextual Flyout #193125

animehart · 2024-09-17T09:17:46Z

Summary

This PR is for Cypress test for the Misconfiguration Preview and Data table

animehart · 2024-09-17T09:17:57Z

/ci

…fix'

animehart · 2024-09-17T09:38:28Z

/ci

…to csp-cypress-hostname

animehart · 2024-09-18T22:41:45Z

/ci

elasticmachine · 2024-09-19T04:44:33Z

Pinging @elastic/kibana-cloud-security-posture (Team:Cloud Security)

...security_solution_cypress/cypress/e2e/explore/hosts/misconfiguration_contextual_flyout.cy.ts

maxcold · 2024-09-20T11:10:06Z

@animehart couple of asks:

can you document on the description how to run these e2e suits locally? and also link these tests in our plugin readme file and how to run them https://github.com/elastic/kibana/tree/main/x-pack/plugins/cloud_security_posture#tests ? so that we keep track of what types of tests we have
We need to add this test suit to our team as owners on the CODEOWNERS file. So that we are pinged for the changes

vgomez-el

LGTM!

kibana-ci · 2024-10-01T08:12:59Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 39e8233

Failed CI Steps

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	20.5MB	20.5MB	+735.0B

History

💛 Build #236515 was flaky 3964c64
💔 Build #236470 failed 7c2f468
💛 Build #235419 was flaky 6e0ae67
💚 Build #234716 succeeded 80d3a01
💔 Build #234710 failed f8ed329

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

angorayc · 2024-10-02T10:21:39Z

...security_solution_cypress/cypress/e2e/explore/hosts/misconfiguration_contextual_flyout.cy.ts

@@ -0,0 +1,232 @@
+/*


Thanks for adding the test. Looks like it's interacting with alerts page and the flyout, shall we move it to x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/expandable_flyout?

ah kk
So I placed that test in the current folder because @machadoum suggested to put it here
would it be better if i move it to x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/expandable_flyout instead ? @machadoum

@animehart If the tested feature is only displayed inside the expandable flyout, placing the test where @angorayc suggested might make sense. But that is up to the @elastic/security-threat-hunting-investigations team to decide since they own the cypress/e2e/investigations folder. I strongly suggest you create a folder for your team (cloud_security_posture?) so you don't depend on other teams for code reviews.

@machadoum
As discussed before, we were planning to add our own folder later, the reason being is because adding a specific folder for our team now will involve further steps to to make the new test to be ran on CI and because of this time constraint we think its better for us to put our test in existing folder for now

seanrathier

LGTM but I have a couple of questions I would like to hear your opinion on.

DM me after for approval

...security_solution_cypress/cypress/e2e/explore/hosts/misconfiguration_contextual_flyout.cy.ts

seanrathier · 2024-10-02T14:41:33Z

...security_solution_cypress/cypress/e2e/explore/hosts/misconfiguration_contextual_flyout.cy.ts

+    });
+
+    it('should display insight tabs and findings table upon clicking on misconfiguration accordion', () => {
+      cy.contains('Failed findings', { timeout: 3000 });


🤔 Whenever I see a time-out in a test, it concerns me that we have a performance issue with the UI (sometimes the test runner).

Have we had to do the same in the Selenium tests for the Findings?

I would have expected with mock data that we should be showing the table in under 3 seconds.

dkirchan · 2024-10-17T11:28:31Z

.buildkite/scripts/steps/functional/cloud_security_posture.sh

+
+echo "--- Cloud Security Posture Workflows Cypress tests"
+
+cd x-pack/plugins/security_solution


This path should be changed to: x-pack/test/security_solution_cypress where the package.json commands and the tests live.

dkirchan · 2024-10-17T11:28:38Z

.buildkite/scripts/steps/functional/cloud_security_posture_serverless.sh

+
+echo "--- Cloud Security Posture Workflows Cypress tests on Serverless"
+
+cd x-pack/plugins/security_solution


This path should be changed to: x-pack/test/security_solution_cypress where the package.json commands and the tests live.

maxcold

lgtm, couple of nit comments. Thanks for incorporating all the feedback!

maxcold · 2024-10-18T11:39:26Z

...solution_cypress/cypress/e2e/cloud_security_posture/misconfiguration_contextual_flyout.cy.ts

+
+const timestamp = Date.now();
+
+// Create a Date object using the timestamp


nit: comments like this doesn't bring any value really as they are just describing the code below as is. So the can be safely removed

maxcold · 2024-10-18T11:39:50Z

...solution_cypress/cypress/e2e/cloud_security_posture/misconfiguration_contextual_flyout.cy.ts

+// Create a Date object using the timestamp
+const date = new Date(timestamp);
+
+// Convert the Date object to ISO 8601 format


nit: same as the comment about, just stating the obvious

maxcold · 2024-10-18T11:45:39Z

...solution_cypress/cypress/e2e/cloud_security_posture/misconfiguration_contextual_flyout.cy.ts

+    });
+
+    afterEach(() => {
+      deleteDataStream();


here it is worth commenting that we deleting the data stream while we don't create it because the data stream is being created automatically when any cloud_security_api is hit

kibanamachine · 2024-10-18T12:39:09Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7174

[✅] Cloud Security Posture - Cypress: 39/39 tests passed.
[✅] [Serverless] Cloud Security Posture - Cypress: 39/39 tests passed.

see run history

MadameSheema · 2024-10-18T13:12:41Z

.github/CODEOWNERS

@@ -1861,8 +1861,8 @@ x-pack/plugins/osquery @elastic/security-defend-workflows
 /x-pack/plugins/fleet/public/applications/fleet/sections/agent_policy/create_package_policy_page/single_page_layout/hooks/setup_technology.* @elastic/fleet @elastic/kibana-cloud-security-posture
 /x-pack/plugins/fleet/public/applications/integrations/sections/epm/screens/detail/components/cloud_posture_third_party_support_callout.* @elastic/fleet @elastic/kibana-cloud-security-posture
 /x-pack/plugins/security_solution/public/cloud_security_posture @elastic/kibana-cloud-security-posture
-/x-pack/test/security_solution_cypress/cypress/e2e/explore/hosts/vulnerabilities_contextual_flyout.cy.ts @elastic/kibana-cloud-security-posture
-
+/x-pack/test/security_solution_cypress/cypress/e2e/investigations/alerts/expandable_flyout/misconfiguration_contextual_flyout.cy.ts @elastic/kibana-cloud-security-posture


Is it possible to move this test to your new folder?

oh woops
missed that

MadameSheema · 2024-10-18T13:13:41Z

x-pack/plugins/cloud_security_posture/README.md

@@ -20,6 +20,7 @@ For general guidelines, read [Kibana Testing Guide](https://www.elastic.co/guide
 1. [End-to-End Tests](../../test/cloud_security_posture_functional/config.ts)
 1. [Serverless API Integration tests](../../test_serverless/api_integration/test_suites/security/config.ts)
 1. [Serverless End-to-End Tests](../../test_serverless/functional/test_suites/security/config.ts)
+1. [Cypress End-to-End Tests (Temporary location)](../../test/security_solution_cypress/cypress/e2e/cloud_security_posture)


Is this going to be a temporary location?

nope, this is going to be the permanent location (unless its a problem ?)

it is not! then let's remove the Temporary location from the readme :)

ah, you mean that text lol
I thought you talking about the directory XD

MadameSheema · 2024-10-18T13:14:13Z

x-pack/plugins/cloud_security_posture/README.md

@@ -73,6 +74,17 @@ yarn test:ftr --config x-pack/test_serverless/api_integration/test_suites/securi
 yarn test:ftr --config x-pack/test_serverless/functional/test_suites/security/config.cloud_security_posture.ts
 ```

+Run [**End-to-End Cypress Tests**](https://github.com/elastic/kibana/tree/main/x-pack/test/security_solution_cypress/cypress):


The README inside the security_solution_cypress folder should be updated as well.

MadameSheema · 2024-10-18T13:16:39Z

...solution_cypress/cypress/e2e/cloud_security_posture/misconfiguration_contextual_flyout.cy.ts

+    });
+
+    it('should display insight tabs and findings table upon clicking on misconfiguration accordion', () => {
+      cy.get(CSP_INSIGHT_MISCONFIGURATION_TITLE).click();


NIT: Wrap this issue into a task method.

MadameSheema · 2024-10-18T13:17:58Z

...solution_cypress/cypress/e2e/cloud_security_posture/misconfiguration_contextual_flyout.cy.ts

+    });
+
+    it('should display insight tabs and findings table upon clicking on misconfiguration accordion', () => {
+      cy.get(CSP_INSIGHT_MISCONFIGURATION_TITLE).click();


NIT: https://github.com/elastic/kibana/pull/193125/files#r1806477238

kibanamachine · 2024-10-18T14:59:51Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7178

[✅] Cloud Security Posture - Cypress: 45/45 tests passed.
[✅] [Serverless] Cloud Security Posture - Cypress: 45/45 tests passed.

see run history

kibanamachine · 2024-10-18T19:27:12Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7187

[✅] Cloud Security Posture - Cypress: 45/45 tests passed.
[✅] [Serverless] Cloud Security Posture - Cypress: 45/45 tests passed.

see run history

elasticmachine · 2024-10-18T20:47:13Z

💛 Build succeeded, but was flaky

Buildkite Build
Commit: 602865d

Failed CI Steps

Jest Tests #18

Test Failures

[job] [logs] Jest Tests #18 / EditableMarkdown Save button click calls onSaveContent and onChangeEditable when text area value changed

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
`securitySolution`	20.7MB	20.7MB	+735.0B

History

💔 Build #243807 failed 9292da7
💚 Build #243654 succeeded bf1f173
💛 Build #243587 was flaky 61b251e
💔 Build #243394 failed 5672e82
💔 Build #243013 failed f21365a

kibanamachine · 2024-10-18T21:26:38Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7189

[✅] Cloud Security Posture - Cypress: 45/45 tests passed.
[✅] [Serverless] Cloud Security Posture - Cypress: 45/45 tests passed.

see run history

kibanamachine · 2024-10-19T05:57:08Z

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7190

[✅] Cloud Security Posture - Cypress: 45/45 tests passed.
[✅] [Serverless] Cloud Security Posture - Cypress: 45/45 tests passed.

see run history

kibanamachine · 2024-10-19T08:40:09Z

Starting backport for target branches: 8.16

https://github.com/elastic/kibana/actions/runs/11416138161

kibanamachine · 2024-10-19T08:44:54Z

💔 All backports failed

Status	Branch	Result
❌	8.16	Backport failed because of merge conflicts

Manual backport

To create the backport manually run:

node scripts/backport --pr 193125

Questions ?

Please refer to the Backport tool documentation

animehart · 2024-10-19T09:01:15Z

💚 All backports created successfully

Status	Branch	Result
✅	8.16

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

initial push: added cypress test for Misconfiguration preview

f8ed329

[CI] Auto-commit changed files from 'node scripts/lint_ts_projects --…

80d3a01

…fix'

animehart added 4 commits September 18, 2024 08:00

update cypress

011fb8f

Merge branch 'csp-cypress-hostname' of github.com:animehart/kibana in…

d19bbc2

…to csp-cypress-hostname

Merge branch 'main' into csp-cypress-hostname

df19df6

added user name contextual flyout cypress

6e0ae67

animehart added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) Team:Cloud Security Cloud Security team related v8.16.0 release_note:skip Skip the PR/issue when compiling release notes labels Sep 19, 2024

animehart marked this pull request as ready for review September 19, 2024 04:44

animehart requested review from a team as code owners September 19, 2024 04:44

maxcold reviewed Sep 20, 2024

View reviewed changes

animehart added 2 commits September 23, 2024 10:15

pr comments

1888ccd

update notes about cypress

7c2f468

animehart changed the title ~~[Cloud Security] Cypress Test for Misconfiguration Preview and Table for Contextual Flyout (Hostname)~~ [Cloud Security] Cypress Test for Misconfiguration Preview and Table for Contextual Flyout Sep 23, 2024

Merge branch 'main' into csp-cypress-hostname

3964c64

vgomez-el approved these changes Sep 30, 2024

View reviewed changes

animehart requested a review from maxcold October 1, 2024 06:23

Merge branch 'main' into csp-cypress-hostname

39e8233

angorayc reviewed Oct 2, 2024

View reviewed changes

seanrathier reviewed Oct 2, 2024

View reviewed changes

animehart added 3 commits October 17, 2024 02:05

fix conflit 1

a6f95ea

fix conflict

499a692

update readme

5672e82

dkirchan approved these changes Oct 17, 2024

View reviewed changes

fix

61b251e

jbudz approved these changes Oct 17, 2024

View reviewed changes

animehart added 3 commits October 18, 2024 02:47

Merge branch 'main' into csp-cypress-hostname

bf1f173

added groups so we can run Cypres on Flaky Test Runner

4c328bb

fix conflict

9292da7

maxcold approved these changes Oct 18, 2024

View reviewed changes

MadameSheema reviewed Oct 18, 2024

View reviewed changes

pr Comments

602865d

animehart added backport:version Backport to applied version labels v9.0.0 and removed backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) labels Oct 19, 2024

animehart merged commit 2de1f4a into elastic:main Oct 19, 2024
50 checks passed

animehart mentioned this pull request Oct 19, 2024

[8.16] [Cloud Security] Cypress Test for Misconfiguration Preview and Table for Contextual Flyout (#193125) #196974

Open


		echo "--- Cloud Security Posture Workflows Cypress tests"

		cd x-pack/plugins/security_solution


		const timestamp = Date.now();

		// Create a Date object using the timestamp

[Cloud Security] Cypress Test for Misconfiguration Preview and Table for Contextual Flyout #193125

[Cloud Security] Cypress Test for Misconfiguration Preview and Table for Contextual Flyout #193125

Conversation

animehart commented Sep 17, 2024 • edited by kibanamachine Loading

Summary

animehart commented Sep 17, 2024

animehart commented Sep 17, 2024

animehart commented Sep 18, 2024

elasticmachine commented Sep 19, 2024

maxcold commented Sep 20, 2024

vgomez-el left a comment

Choose a reason for hiding this comment

kibana-ci commented Oct 1, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Metrics [docs]

Async chunks

History

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

seanrathier left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

maxcold left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kibanamachine commented Oct 18, 2024

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7174

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

kibanamachine commented Oct 18, 2024

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7178

kibanamachine commented Oct 18, 2024

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7187

elasticmachine commented Oct 18, 2024

💛 Build succeeded, but was flaky

Failed CI Steps

Test Failures

Metrics [docs]

Async chunks

History

kibanamachine commented Oct 18, 2024

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7189

kibanamachine commented Oct 19, 2024

Flaky Test Runner Stats

🎉 All tests passed! - kibana-flaky-test-suite-runner#7190

kibanamachine commented Oct 19, 2024

kibanamachine commented Oct 19, 2024

💔 All backports failed

Manual backport

Questions ?

animehart commented Oct 19, 2024

💚 All backports created successfully

Questions ?

animehart commented Sep 17, 2024 •

edited by kibanamachine

Loading