[Lens][Telemetry] Track Elasticsearch took time in Lens editor
#192245
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markov00
added
performance
release_note:skip
markov00
force-pushed
the
2024_09_06-extract_es_took_time
branch
from
d056529 to
b3ff7fe
Compare
dej611
approved these changes
Sep 9, 2024
...ck/plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel.tsx
Outdated
Show resolved
Hide resolved
💚 Build Succeeded
Metrics [docs]Async chunks
History
To update your PR or re-run it, just comment with: |
|
thanks @markov00 ! I added some additional information here #189396 (comment). Ideally, we can collect this metric in all contexts where Lens is rendered. |
2 tasks
1 task
thomasneirynck
added a commit
that referenced
this pull request
Sep 20, 2024
## Summary Similar to #192245, this adds request-time to the Lens Embeddable. This would allow to track these metrics anywhere where Lens is embedded. This is particularly important for Lens embedded in a Dashboard since all performance journeys are written against Dashboards. ### Checklist Delete any items that are not applicable to this PR. - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com>
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Sep 23, 2024
## Summary Similar to elastic#192245, this adds request-time to the Lens Embeddable. This would allow to track these metrics anywhere where Lens is embedded. This is particularly important for Lens embedded in a Dashboard since all performance journeys are written against Dashboards. ### Checklist Delete any items that are not applicable to this PR. - [x] This was checked for [cross-browser compatibility](https://www.elastic.co/support/matrix#matrix_browsers) ### For maintainers - [x] This was checked for breaking API changes and was [labeled appropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process) --------- Co-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com> Co-authored-by: Marco Vettorello <vettorello.marco@gmail.com> (cherry picked from commit 682afb7)
kibanamachine
added a commit
that referenced
this pull request
Sep 23, 2024
… (#193740) # Backport This will backport the following commits from `main` to `8.x`: - [[Lens] Add ES-request time telemetry to Lens embeddable (#192743)](#192743) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Thomas Neirynck","email":"thomas@elastic.co"},"sourceCommit":{"committedDate":"2024-09-20T13:24:19Z","message":"[Lens] Add ES-request time telemetry to Lens embeddable (#192743)\n\n## Summary\r\n\r\nSimilar to #192245, this adds\r\nrequest-time to the Lens Embeddable. This would allow to track these\r\nmetrics anywhere where Lens is embedded.\r\n\r\nThis is particularly important for Lens embedded in a Dashboard since\r\nall performance journeys are written against Dashboards.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Marco Vettorello <vettorello.marco@gmail.com>","sha":"682afb7d8cf2712c2a4d3c64820e4baf2af100bf","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["release_note:skip","v9.0.0","telemetry","v8.16.0","backport:version"],"title":"[Lens] Add ES-request time telemetry to Lens embeddable","number":192743,"url":"https://github.com/elastic/kibana/pull/192743","mergeCommit":{"message":"[Lens] Add ES-request time telemetry to Lens embeddable (#192743)\n\n## Summary\r\n\r\nSimilar to #192245, this adds\r\nrequest-time to the Lens Embeddable. This would allow to track these\r\nmetrics anywhere where Lens is embedded.\r\n\r\nThis is particularly important for Lens embedded in a Dashboard since\r\nall performance journeys are written against Dashboards.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Marco Vettorello <vettorello.marco@gmail.com>","sha":"682afb7d8cf2712c2a4d3c64820e4baf2af100bf"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/192743","number":192743,"mergeCommit":{"message":"[Lens] Add ES-request time telemetry to Lens embeddable (#192743)\n\n## Summary\r\n\r\nSimilar to #192245, this adds\r\nrequest-time to the Lens Embeddable. This would allow to track these\r\nmetrics anywhere where Lens is embedded.\r\n\r\nThis is particularly important for Lens embedded in a Dashboard since\r\nall performance journeys are written against Dashboards.\r\n\r\n### Checklist\r\n\r\nDelete any items that are not applicable to this PR.\r\n\r\n- [x] This was checked for [cross-browser\r\ncompatibility](https://www.elastic.co/support/matrix#matrix_browsers)\r\n\r\n\r\n### For maintainers\r\n\r\n- [x] This was checked for breaking API changes and was [labeled\r\nappropriately](https://www.elastic.co/guide/en/kibana/master/contributing.html#kibana-release-notes-process)\r\n\r\n---------\r\n\r\nCo-authored-by: kibanamachine <42973632+kibanamachine@users.noreply.github.com>\r\nCo-authored-by: Marco Vettorello <vettorello.marco@gmail.com>","sha":"682afb7d8cf2712c2a4d3c64820e4baf2af100bf"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}] BACKPORT--> Co-authored-by: Thomas Neirynck <thomas@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This implements the requirement to separate ES query time from the
time_to_datatelemetry. It currently separates only the Elasticsearchtooktime available in the response and works only in the EBT performance journey for the Lens Editor implemented in #163412.