[APM] Update Cypress command to access super date picker #191949
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
tonyghiani
added
the
release_note:skip
tonyghiani
commented
Sep 3, 2024
Comment on lines
+91
to
+92
| cy.getByTestSubj('superDatePickerAbsoluteDateInput').clear({ force: true }); | ||
| cy.getByTestSubj('superDatePickerAbsoluteDateInput') |
There was a problem hiding this comment.
Important
This element query is not chained to prevent incurring this detached reference error.
cauemarcondes
approved these changes
Sep 3, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest Failures
Metrics [docs]
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.16.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📓 Summary
Given a change in the HTML structure of the SuperDatePicker component from EUI, the
selectAbsoluteTimeRangewas no longer capable of typing the passed date.Once the PR to update EUI was merged, it didn't go through the APM Cypress suite since those files where not touched, causing the false positive in the CI step.
This change directly accesses the input field without relying on sibling elements.