-
Notifications
You must be signed in to change notification settings - Fork 8.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[EDR Workflows] Automated Actions in more rule types #191874
Merged
Merged
Changes from 39 commits
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
5fb4a70
response actions in eql and esql rules
tomsonpl 96c92ed
Merge branch 'main' into automated-in-all-rules
tomsonpl 2b342da
limit to esql and eql
tomsonpl 0db366d
add type
tomsonpl e9b272c
fix types
tomsonpl 45c6f9a
fix cy test
tomsonpl a07a932
Merge branch 'main' into automated-in-all-rules
tomsonpl 90990df
[CI] Auto-commit changed files from 'yarn openapi:bundle'
kibanamachine 5c3701b
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine 3a983f9
snapshots
tomsonpl ac7010c
Merge remote-tracking branch 'origin/automated-in-all-rules' into aut…
tomsonpl 62f3045
Merge branch 'main' into automated-in-all-rules
tomsonpl e3cef1a
fix
tomsonpl 28a93d2
rename type
tomsonpl f566043
roll back ThresholdRule position
maximpn e878208
Merge branch 'main' into automated-in-all-rules
tomsonpl 4e3be88
pass response actions to more rules
tomsonpl 4bdb90c
Merge remote-tracking branch 'origin/automated-in-all-rules' into aut…
tomsonpl 9453127
[CI] Auto-commit changed files from 'yarn openapi:bundle'
kibanamachine a73360b
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine 8cd270d
fix tests, remove TypeSpecificFields filter
tomsonpl f989c37
Merge remote-tracking branch 'origin/automated-in-all-rules' into aut…
tomsonpl 64dffe1
fix e2e
tomsonpl 3e46918
fix header
tomsonpl 3977af5
temporary hide other rule types - intermediate release
tomsonpl eac4b45
intermediate release - comment out e2e test
tomsonpl cab1f84
Update form.cy.ts
tomsonpl 618982b
Merge branch 'main' into automated-in-all-rules
tomsonpl 3fc2bcf
feature flag
tomsonpl 708905a
fix
tomsonpl 28e37f2
fixes
tomsonpl a27a0dd
Merge branch 'main' into automated-in-all-rules
tomsonpl 07a573c
[CI] Auto-commit changed files from 'node scripts/eslint --no-cache -…
kibanamachine 16a534c
fix
tomsonpl 2f79a3d
Merge remote-tracking branch 'origin/automated-in-all-rules' into aut…
tomsonpl 6f0e36e
use TypeSpecificCreatePropsInternal instead of TypeSpecificFields
tomsonpl c1536b9
Merge branch 'main' into automated-in-all-rules
tomsonpl 81fc160
Merge branch 'main' into automated-in-all-rules
tomsonpl 6a39a14
Merge branch 'main' into automated-in-all-rules
tomsonpl ebf458d
Merge branch 'main' into automated-in-all-rules
tomsonpl ee68d55
move back response_actions to typespecific rules
tomsonpl 1dc5cf4
move condition logic to scheduleNotificationResponseActionsService
tomsonpl 412e456
Merge remote-tracking branch 'origin/automated-in-all-rules' into aut…
tomsonpl 69d9cd0
tests
tomsonpl d787d0a
[CI] Auto-commit changed files from 'yarn openapi:bundle'
kibanamachine e2680e9
fix
tomsonpl 6215ded
Merge remote-tracking branch 'origin/automated-in-all-rules' into aut…
tomsonpl 87c0c8b
fix tests
tomsonpl 2b7c7f4
fix license header again
tomsonpl ade46fd
remove redundant spaces
tomsonpl File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
1,661 changes: 1,247 additions & 414 deletions
1,661
...erver/integration_tests/__snapshots__/serverless_upgrade_and_rollback_checks.test.ts.snap
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel the following representation of the logic is a bit clearer.
The current implementation reads as "show response actions if feature flag is true then is it one of these rule types, if not, is it a query rule"
I think my suggestion is a bit clearer - "show response actions if it's a query rule or the feature flag is enabled AND it's one of these rule types"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sure, this makes sense to me too 👍 however, need to mention that the feature flag will get removed in the following serverless release.