[APM] Fix APM breadcrumbs on Serverless #191506
Conversation
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
|
/ci |
crespocarlos
force-pushed
the
a11y-fix-apm-breadcrumbs
branch
from
b9701c1
to
f2dbcd2
Compare
|
/ci |
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/obs-ux-management-team (Team:obs-ux-management) |
|
Pinging @elastic/obs-ux-infra_services-team (Team:obs-ux-infra_services) |
crespocarlos
added
v8.16.0
release_note:skip
| [core.http.basePath, href, title] | ||
| [core.http.basePath, href, title], | ||
| { | ||
| omitOnServerless, |
There was a problem hiding this comment.
Note
Side nav items are automatically added, so we have to avoid adding repeated items to the breadcrumbs
botelastic
bot
added
the
Team:obs-ux-management
| ], | ||
| [pagePath, pageTitle, query, router, selectedTab, serviceGroupName, serviceGroupsLink], | ||
| { | ||
| omitRootOnServerless: true, |
There was a problem hiding this comment.
Note
Services is automatically added on serverless
| @@ -50,11 +49,13 @@ function serviceGroupPage<TPath extends string>({ | |||
| return { | |||
| [path]: { | |||
| element: ( | |||
| <Breadcrumb title={title} href={path}> | |||
There was a problem hiding this comment.
Note
was removed to avoid conflicts with useBreadcrumb in ServiceGroupTemplate
There was a problem hiding this comment.
totally off topic: never knew about these alert indicators. I'll immediately start (ab)-using these! :)
Other type of alerts per my recent findings:
Note
Highlights information that users should take into account, even when skimming.
Tip
Optional information to help a user be more successful.
Important
Crucial information necessary for users to succeed.
Warning
Critical content demanding immediate user attention due to potential risks.
Caution
Negative potential consequences of an action.
There was a problem hiding this comment.
I have to say that I found that out a couple of days ago in one of @tonyghiani's PRs. 😄
|
@elasticmachine merge upstream |
💚 Build Succeeded
Metrics [docs]Async chunks
Page load bundle
History
To update your PR or re-run it, just comment with: |
fixes #8
fixes #7
Summary
Fixes APM breadcrumbs on serverless
How to test
Serverless
yarn es serverless --projectType=oblt --ssl -k/--insecureyarn start --serverless=oblt --no-sslNODE_TLS_REJECT_UNAUTHORIZED=0 node scripts/synthtrace mobile.ts --live --target=https://elastic_serverless:changeme@127.0.0.1:9200 --kibana=http://elastic_serverless:changeme@0.0.0.0:5601NODE_TLS_REJECT_UNAUTHORIZED=0 node scripts/synthtrace service_map.ts --live --target=https://elastic_serverless:changeme@127.0.0.1:9200 --kibana=http://elastic_serverless:changeme@0.0.0.0:5601Stateful
node scripts/synthtrace mobile.ts --livenode scripts/synthtrace service_map.ts --live