[Observability Onboarding] Split Agent config into multiple files #191241
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🤖 GitHub commentsExpand to view the GitHub comments
Just comment with:
|
…nboarding-agent-config
thomheymann
commented
Sep 2, 2024
| @@ -1229,7 +1229,7 @@ | |||
| "suricata-sid-db": "^1.0.2", | |||
| "swr": "^2.2.5", | |||
| "symbol-observable": "^1.2.0", | |||
| "tar": "^6.2.1", | |||
| "tar": "^7.4.3", | |||
There was a problem hiding this comment.
I had to update this package to the latest version since v6 did not export the required lower level functions.
| @@ -1609,7 +1609,6 @@ | |||
| "@types/styled-components": "^5.1.0", | |||
| "@types/supertest": "^6.0.2", | |||
| "@types/tapable": "^1.0.6", | |||
| "@types/tar": "^6.1.11", | |||
There was a problem hiding this comment.
v7 ships with type definitions so was able to remove @types/tar package.
botelastic
bot
added
ci:project-deploy-observability
|
Pinging @elastic/fleet (Team:Fleet) |
thomheymann
added
the
release_note:skip
mykolaharmash
approved these changes
Sep 2, 2024
|
/ci |
1 similar comment
|
/ci |
delanni
approved these changes
Sep 3, 2024
💛 Build succeeded, but was flaky
Failed CI StepsMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
added
v8.16.0
backport:skip
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #191917
Summary
Splits up the Agent config generated during auto-detect based onboarding into multiple files.
This makes it easier for users to make changes following the initial onboarding.
The backup feature has also been updated to include files inside
inputs.ddirectory.Example
Before this change the auto-detect script would write all settings to
elastic-agent.ymlfile.After this change the script writes one separate config file for each integrations that was detected, for example:
elastic-agent.yml- Contains global settingsinputs.d/system.yml- Contains inputs config for System integrationinputs.d/docker.yml- Contains inputs config for Docker integrationScreenshot