[ES|QL] Open the suggestion menu when the editor is focused and empty

[drewdaemon]

Summary

Opens the suggestions menu whenever the editor is focused and empty.

Screen.Recording.2024-08-22.at.3.17.52.PM.mov

[drewdaemon]

@ryankeairns is this the kind of thing you're thinking?

[ryankeairns]

@ryankeairns is this the kind of thing you're thinking?

Indeed. FROM seems the most likely starting point for many, many queries.

[drewdaemon]

/ci

[drewdaemon]

@elasticmachine merge upstream

[drewdaemon]

/ci

[elasticmachine]

Pinging @elastic/kibana-esql (Team:ESQL)

[stratoula]

/ci

[stratoula]

@drewdaemon can you check why we are adding 130KB in the esql async chunk?? We can't merge it like that.

It must be this import

import { TRIGGER_SUGGESTION_COMMAND } from '@kbn/esql-validation-autocomplete/src/autocomplete/factories';

Maybe we need to move some constants in the esql-utils. Let's discuss when you are available!

[kibana-ci]

💚 Build Succeeded

• Buildkite Build
• Commit: e500b01

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id	before	after	diff
esql	82	84	+2
stackAlerts	153	155	+2
total			+4

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id	before	after	diff
esql	176.5KB	180.8KB	+4.3KB

History

• 💛 Build #229664 was flaky e9b4d85
• 💛 Build #229578 was flaky 7c23cab
• 💚 Build #229538 succeeded 7c23cab
• 💔 Build #229482 failed 43ad25c

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

[drewdaemon]

@stratoula good catch I removed that import.

[ryankeairns]

Thanks for this. I can now write an entire query using autocomplete with a down arrow and the return key.
But seriously, that first hurdle - first command - is an important one in getting the ball rolling.

[qn895]

LGTM 🎉

[stratoula]

Thanx Drew