Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Detection Engine] add validation for new terms history window #191038

Merged
merged 7 commits into from
Oct 4, 2024

Conversation

yctercero
Copy link
Contributor

@yctercero yctercero commented Aug 22, 2024

Summary

Addresses #164525

Screenshot 2024-08-21 at 6 58 43 PM

Checklist

@yctercero yctercero requested a review from a team as a code owner August 22, 2024 00:39
@yctercero yctercero added bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area v8.16.0 labels Aug 22, 2024
@yctercero yctercero self-assigned this Aug 22, 2024
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-detection-engine (Team:Detection Engine)

@yctercero yctercero added backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) backport:prev-major Backport to (8.x, 8.16, 8.15) the previous major branch and all later branches still in development labels Sep 30, 2024
@kibana-ci
Copy link
Collaborator

💚 Build Succeeded

Metrics [docs]

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.5MB 20.6MB +1.7KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @yctercero

@yctercero yctercero merged commit 6001786 into elastic:main Oct 4, 2024
40 checks passed
@kibanamachine
Copy link
Contributor

Starting backport for target branches: 8.15, 8.x

https://github.com/elastic/kibana/actions/runs/11182069716

@kibanamachine
Copy link
Contributor

💚 All backports created successfully

Status Branch Result
8.15
8.x

Note: Successful backport PRs will be merged automatically after passing CI.

Questions ?

Please refer to the Backport tool documentation

kibanamachine added a commit that referenced this pull request Oct 4, 2024
…#191038) (#195091)

# Backport

This will backport the following commits from `main` to `8.15`:
- [[Detection Engine] add validation for new terms history window
(#191038)](#191038)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Yara
Tercero","email":"yctercero@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-04T14:47:32Z","message":"[Detection
Engine] add validation for new terms history window (#191038)\n\n##
Summary\r\n\r\nAddresses
https://github.com/elastic/kibana/issues/164525","sha":"6001786d04388f5f79cea74b674e510fc7a60d3a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","backport:prev-minor","backport:prev-major","Team:Detection
Engine","v8.16.0"],"title":"[Detection Engine] add validation for new
terms history
window","number":191038,"url":"https://github.com/elastic/kibana/pull/191038","mergeCommit":{"message":"[Detection
Engine] add validation for new terms history window (#191038)\n\n##
Summary\r\n\r\nAddresses
https://github.com/elastic/kibana/issues/164525","sha":"6001786d04388f5f79cea74b674e510fc7a60d3a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/191038","number":191038,"mergeCommit":{"message":"[Detection
Engine] add validation for new terms history window (#191038)\n\n##
Summary\r\n\r\nAddresses
https://github.com/elastic/kibana/issues/164525","sha":"6001786d04388f5f79cea74b674e510fc7a60d3a"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
kibanamachine added a commit that referenced this pull request Oct 4, 2024
…191038) (#195092)

# Backport

This will backport the following commits from `main` to `8.x`:
- [[Detection Engine] add validation for new terms history window
(#191038)](#191038)

<!--- Backport version: 9.4.3 -->

### Questions ?
Please refer to the [Backport tool
documentation](https://github.com/sqren/backport)

<!--BACKPORT [{"author":{"name":"Yara
Tercero","email":"yctercero@users.noreply.github.com"},"sourceCommit":{"committedDate":"2024-10-04T14:47:32Z","message":"[Detection
Engine] add validation for new terms history window (#191038)\n\n##
Summary\r\n\r\nAddresses
https://github.com/elastic/kibana/issues/164525","sha":"6001786d04388f5f79cea74b674e510fc7a60d3a","branchLabelMapping":{"^v9.0.0$":"main","^v8.16.0$":"8.x","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["bug","release_note:skip","v9.0.0","backport:prev-minor","backport:prev-major","Team:Detection
Engine","v8.16.0"],"title":"[Detection Engine] add validation for new
terms history
window","number":191038,"url":"https://github.com/elastic/kibana/pull/191038","mergeCommit":{"message":"[Detection
Engine] add validation for new terms history window (#191038)\n\n##
Summary\r\n\r\nAddresses
https://github.com/elastic/kibana/issues/164525","sha":"6001786d04388f5f79cea74b674e510fc7a60d3a"}},"sourceBranch":"main","suggestedTargetBranches":["8.x"],"targetPullRequestStates":[{"branch":"main","label":"v9.0.0","branchLabelMappingKey":"^v9.0.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/191038","number":191038,"mergeCommit":{"message":"[Detection
Engine] add validation for new terms history window (#191038)\n\n##
Summary\r\n\r\nAddresses
https://github.com/elastic/kibana/issues/164525","sha":"6001786d04388f5f79cea74b674e510fc7a60d3a"}},{"branch":"8.x","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":false,"state":"NOT_CREATED"}]}]
BACKPORT-->

Co-authored-by: Yara Tercero <yctercero@users.noreply.github.com>
jbudz pushed a commit to jbudz/kibana that referenced this pull request Oct 4, 2024
tiansivive pushed a commit to tiansivive/kibana that referenced this pull request Oct 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport:prev-major Backport to (8.x, 8.16, 8.15) the previous major branch and all later branches still in development backport:prev-minor Backport to (8.x) the previous minor version (i.e. one version back from main) bug Fixes for quality problems that affect the customer experience release_note:skip Skip the PR/issue when compiling release notes Team:Detection Engine Security Solution Detection Engine Area v8.15.3 v8.16.0 v9.0.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants