Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Security Solution] Add content to the new Data Ingestion Hub header #189969

Conversation

agusruidiazgd
Copy link
Contributor

@agusruidiazgd agusruidiazgd commented Aug 6, 2024

Summary

Align the header styles with the latest design:

Screenshot 2024-08-07 at 10 23 45 Screenshot 2024-08-07 at 10 24 53

Checklist

Delete any items that are not applicable to this PR.

@agusruidiazgd agusruidiazgd self-assigned this Aug 6, 2024
@agusruidiazgd agusruidiazgd added 8.16 candidate Team:Threat Hunting:Explore release_note:skip Skip the PR/issue when compiling release notes ci:cloud-deploy Create or update a Cloud deployment backport:skip This commit does not require backporting labels Aug 7, 2024
@agusruidiazgd agusruidiazgd marked this pull request as ready for review August 7, 2024 08:27
@agusruidiazgd agusruidiazgd requested review from a team as code owners August 7, 2024 08:27
@elasticmachine
Copy link
Contributor

Pinging @elastic/security-threat-hunting-explore (Team:Threat Hunting:Explore)

@angorayc
Copy link
Contributor

angorayc commented Aug 7, 2024

Hey @agusruidiazgd , thanks for updating the header. I checked the view when feature flag was off and found some styling issues, can you please check again?

Screenshot 2024-08-07 at 10 06 24

Copy link
Contributor

@angorayc angorayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A minor styling issue found: #189969 (comment)

@agusruidiazgd
Copy link
Contributor Author

@angorayc this is how it looks now 😃

  • feature flag disabled:
Screenshot 2024-08-07 at 15 29 27
  • feature flag enabled:
Screenshot 2024-08-07 at 15 30 19

@kibana-ci
Copy link
Collaborator

kibana-ci commented Aug 7, 2024

💚 Build Succeeded

Metrics [docs]

Module Count

Fewer modules leads to a faster build time

id before after diff
securitySolution 5610 5613 +3

Async chunks

Total size of all lazy-loaded chunks that will be downloaded as the user navigates the app

id before after diff
securitySolution 20.5MB 20.5MB +2.3KB
Unknown metric groups

miscellaneous assets size

id before after diff
securitySolution 6.3MB 6.3MB +51.0KB

History

To update your PR or re-run it, just comment with:
@elasticmachine merge upstream

cc @agusruidiazgd

Copy link
Contributor

@angorayc angorayc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix, LGTM!

@agusruidiazgd agusruidiazgd merged commit 87bf9b2 into elastic:main Aug 8, 2024
40 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.16 candidate backport:skip This commit does not require backporting ci:cloud-deploy Create or update a Cloud deployment release_note:skip Skip the PR/issue when compiling release notes Team:Threat Hunting:Explore v8.16.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants