-
Notifications
You must be signed in to change notification settings - Fork 8.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert "chore(NA): skip defend workflows tests failing because of vagrant (#189723) #189753
Merged
jbudz
merged 2 commits into
elastic:main
from
mistic:revert-skip-tests-dependant-on-vagrant
Aug 1, 2024
Merged
Revert "chore(NA): skip defend workflows tests failing because of vagrant (#189723) #189753
jbudz
merged 2 commits into
elastic:main
from
mistic:revert-skip-tests-dependant-on-vagrant
Aug 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rant (elastic#189723)" This reverts commit 3d9d7df.
mistic
added
chore
Team:Operations
Team label for Operations Team
release_note:skip
Skip the PR/issue when compiling release notes
v8.16.0
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
labels
Aug 1, 2024
paul-tavares
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you
buildkite test this |
joeypoon
approved these changes
Aug 1, 2024
💛 Build succeeded, but was flaky
Failed CI StepsTest FailuresMetrics [docs]
History
To update your PR or re-run it, just comment with: |
kibanamachine
pushed a commit
to kibanamachine/kibana
that referenced
this pull request
Aug 1, 2024
…rant (elastic#189723) (elastic#189753) (cherry picked from commit e13a1ba)
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
kibanamachine
added a commit
that referenced
this pull request
Aug 2, 2024
…cause of vagrant (#189723) (#189753) (#189766) # Backport This will backport the following commits from `main` to `8.15`: - [Revert "chore(NA): skip defend workflows tests failing because of vagrant (#189723) (#189753)](#189753) <!--- Backport version: 9.4.3 --> ### Questions ? Please refer to the [Backport tool documentation](https://github.com/sqren/backport) <!--BACKPORT [{"author":{"name":"Tiago Costa","email":"tiago.costa@elastic.co"},"sourceCommit":{"committedDate":"2024-08-01T23:11:46Z","message":"Revert \"chore(NA): skip defend workflows tests failing because of vagrant (#189723) (#189753)","sha":"e13a1baf72bb8250375aaa52a371cb6f34d99d53","branchLabelMapping":{"^v8.16.0$":"main","^v(\\d+).(\\d+).\\d+$":"$1.$2"}},"sourcePullRequest":{"labels":["chore","Team:Operations","release_note:skip","backport:prev-minor","v8.16.0"],"title":"Revert \"chore(NA): skip defend workflows tests failing because of vagrant (#189723)","number":189753,"url":"https://github.com/elastic/kibana/pull/189753","mergeCommit":{"message":"Revert \"chore(NA): skip defend workflows tests failing because of vagrant (#189723) (#189753)","sha":"e13a1baf72bb8250375aaa52a371cb6f34d99d53"}},"sourceBranch":"main","suggestedTargetBranches":[],"targetPullRequestStates":[{"branch":"main","label":"v8.16.0","branchLabelMappingKey":"^v8.16.0$","isSourceBranch":true,"state":"MERGED","url":"https://github.com/elastic/kibana/pull/189753","number":189753,"mergeCommit":{"message":"Revert \"chore(NA): skip defend workflows tests failing because of vagrant (#189723) (#189753)","sha":"e13a1baf72bb8250375aaa52a371cb6f34d99d53"}}]}] BACKPORT--> Co-authored-by: Tiago Costa <tiago.costa@elastic.co>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
backport:prev-minor
Backport to (8.x) the previous minor version (i.e. one version back from main)
chore
release_note:skip
Skip the PR/issue when compiling release notes
Team:Operations
Team label for Operations Team
v8.15.0
v8.16.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
null